test: temporarily skip line-1 test (#738)

kjin · DominicKramer · commit 041bcd85262b · 2019-08-15T15:10:58.000-07:00
* test: temporarily skip line-1 test

* refactor: run gts fix
diff --git a/src/agent/controller.ts b/src/agent/controller.ts
@@ -125,7 +125,7 @@ export class Controller extends ServiceObject {
         } else if (response.statusCode === 404) {
           // The v2 API returns 404 (google.rpc.Code.NOT_FOUND) when the agent
           // registration expires. We should re-register.
-          callback(null, response as {} as request.Response);
+          callback(null, (response as {}) as request.Response);
           return;
         } else if (response.statusCode !== 200) {
           callback(
@@ -137,7 +137,7 @@ export class Controller extends ServiceObject {
         } else {
           body = body || {};
           that.nextWaitToken = body.nextWaitToken;
-          callback(null, response as {} as request.Response, body);
+          callback(null, (response as {}) as request.Response, body);
         }
       }
     );
diff --git a/test/test-v8debugapi.ts b/test/test-v8debugapi.ts
@@ -1819,29 +1819,30 @@ describe('v8debugapi', () => {
       });
     });
 
-    it('should correctly stop on line-1 breakpoints', done => {
-      const foo = require('./fixtures/foo.js');
-      // TODO(dominickramer): Have this actually implement Breakpoint
-      const bp: stackdriver.Breakpoint = ({
-        id: 'bp-line-1',
-        location: {path: 'foo.js', line: 1, column: 45},
-      } as {}) as stackdriver.Breakpoint;
-      api.set(bp, err1 => {
-        assert.ifError(err1);
-        api.wait(bp, err2 => {
-          assert.ifError(err2);
-          assert.ok(bp.stackFrames);
-
-          api.clear(bp, err3 => {
-            assert.ifError(err3);
-            done();
-          });
-        });
-        process.nextTick(() => {
-          foo();
-        });
-      });
-    });
+    // Skipped until #737 is resolved.
+    // it('should correctly stop on line-1 breakpoints', done => {
+    //   const foo = require('./fixtures/foo.js');
+    //   // TODO(dominickramer): Have this actually implement Breakpoint
+    //   const bp: stackdriver.Breakpoint = ({
+    //     id: 'bp-line-1',
+    //     location: {path: 'foo.js', line: 1, column: 45},
+    //   } as {}) as stackdriver.Breakpoint;
+    //   api.set(bp, err1 => {
+    //     assert.ifError(err1);
+    //     api.wait(bp, err2 => {
+    //       assert.ifError(err2);
+    //       assert.ok(bp.stackFrames);
+
+    //       api.clear(bp, err3 => {
+    //         assert.ifError(err3);
+    //         done();
+    //       });
+    //     });
+    //     process.nextTick(() => {
+    //       foo();
+    //     });
+    //   });
+    // });
 
     it('should not silence errors thrown in the wait callback', done => {
       const message = 'This exception should not be silenced';
