Free the GL context when OffScreenRenderer.release() is called.

nimrod-gileadi · copybara-github · commit ee1dfa09f2c5 · 2022-03-18T08:43:01.000-07:00
After the previous change, the surface would only be released if there was an active MjrContext. This seems to be the case in practice, but it since it's possible for OffScreenRenderer to exist without an active MjrContext (before rendering), it makes sense to manage the GL context separately.

PiperOrigin-RevId: 435647965
Change-Id: I58da564dc4a7e04d77a2652c7511f03351fb84c6
diff --git a/dm_control/viewer/renderer.py b/dm_control/viewer/renderer.py
@@ -173,8 +173,10 @@ def release(self):
     if self._mujoco_context:
       self._mujoco_context.free()
       self._mujoco_context = None
+    if self._surface:
       self._surface.decrement_refcount()
       self._surface.free()
+      self._surface = None
 
   @property
   def pixels(self):
