python: fix re2.search(compiled, text)

rsc · rsc · commit 45150b3d15fa · 2025-08-04T16:11:00.000-07:00
The old code was accidentally recompiling the pattern and losing the options, both inefficient and incorrect. Thanks to @MajorTanya for the excellent diagnosis. This bug was introduced in CL 60290 and then copied over from the Abseil branch. Fixes #558. Change-Id: I072707003b444fb0934a310e14147b4d65b9da11 Reviewed-on: https://code-review.googlesource.com/c/re2/+/63830 Reviewed-by: Alan Donovan <adonovan@google.com>
diff --git a/python/re2.py b/python/re2.py
@@ -64,7 +64,7 @@ def compile(pattern, options=None):
     if options:
       raise error('pattern is already compiled, so '
                   'options may not be specified')
-    pattern = pattern._pattern
+    return pattern
   options = options or Options()
   values = tuple(getattr(options, name) for name in Options.NAMES)
   return _Regexp._make(pattern, values)
diff --git a/python/re2_test.py b/python/re2_test.py
@@ -315,6 +315,12 @@ def test_purge(self):
     re2.purge()
     self.assertEqual(re2._Regexp._make.cache_info().currsize, 0)
 
+  def test_options(self):
+    opt = re2.Options()
+    opt.case_sensitive = False
+    r = re2.compile('test', opt)
+    self.assertIsNotNone(r.search('TEST'))
+    self.assertIsNotNone(re2.search(r, 'TEST'))
 
 class Re2EscapeTest(parameterized.TestCase):
   """Contains tests that apply to the re2 module only.
