Skip to content

Commit 019bed1

Browse files
committed
re2: make CI checks also PR checks
Also incorporate BUILD updates from #584 and a few more checks to make Bazel work again.
1 parent e7aec59 commit 019bed1

5 files changed

Lines changed: 14 additions & 8 deletions

File tree

.github/workflows/ci-bazel.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: CI (Bazel)
22
on:
3+
pull_request:
4+
branches: [main]
35
push:
46
branches: [main, rsc-testing]
57
permissions:
@@ -13,8 +15,6 @@ jobs:
1315
os: [macos-latest, ubuntu-latest, windows-latest]
1416
# Keep in sync with python.yml.
1517
ver: ['3.10', '3.11', '3.12', '3.13', '3.14']
16-
env:
17-
BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1818
steps:
1919
- uses: actions/checkout@v4.2.2
2020
- uses: bazel-contrib/setup-bazel@0.15.0

.github/workflows/ci-cmake.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: CI (CMake)
22
on:
3+
pull_request:
4+
branches: [main]
35
push:
46
branches: [main, rsc-testing]
57
permissions:

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: CI
22
on:
3+
pull_request:
4+
branches: [main]
35
push:
46
branches: [main, rsc-testing]
57
permissions:

MODULE.bazel

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ module(
1111
)
1212

1313
bazel_dep(name = "platforms", version = "1.0.0")
14-
bazel_dep(name = "apple_support", version = "1.23.1")
15-
bazel_dep(name = "rules_cc", version = "0.1.4")
16-
bazel_dep(name = "abseil-cpp", version = "20250512.1")
17-
bazel_dep(name = "rules_python", version = "1.5.1")
18-
bazel_dep(name = "pybind11_bazel", version = "2.13.6")
14+
bazel_dep(name = "apple_support", version = "1.24.2")
15+
bazel_dep(name = "rules_cc", version = "0.2.14")
16+
bazel_dep(name = "abseil-cpp", version = "20250814.1")
17+
bazel_dep(name = "rules_python", version = "1.7.0")
18+
bazel_dep(name = "pybind11_bazel", version = "3.0.0")
1919

2020
# This is a temporary hack for `x64_x86_windows`.
2121
# TODO(junyer): Remove whenever no longer needed.
@@ -25,5 +25,5 @@ use_repo(cc_configure, "local_config_cc")
2525
# These dependencies will be ignored when the `re2` module is not
2626
# the root module (or when `--ignore_dev_dependency` is enabled).
2727
bazel_dep(name = "google_benchmark", version = "1.9.4", dev_dependency = True)
28-
bazel_dep(name = "googletest", version = "1.17.0", dev_dependency = True)
28+
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True)
2929
bazel_dep(name = "abseil-py", version = "2.1.0", dev_dependency = True)

python/toolchains/generate.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ def generate():
2323
with open(f'{mydir}/BUILD.bazel', 'x') as file:
2424
file.write(
2525
"""\
26+
load("@rules_cc//cc:cc_import.bzl", "cc_import")
27+
load("@rules_cc//cc:cc_library.bzl", "cc_library")
2628
load("@rules_python//python/cc:py_cc_toolchain.bzl", "py_cc_toolchain")
2729
load("@rules_python//python:py_runtime.bzl", "py_runtime")
2830
load("@rules_python//python:py_runtime_pair.bzl", "py_runtime_pair")

0 commit comments

Comments
 (0)