It looks like we already support bytes and arrays of bytes in conditions, just not in fields:

python-spanner-orm/spanner_orm/condition.py

Lines 221 to 234 in 2ae8e42

    
           # BYTES must be base64-encoded, see 
        
           # https://github.com/googleapis/python-spanner/blob/87789c939990794bfd91f5300bedc449fd74bd7e/google/cloud/spanner_v1/proto/type.proto#L108-L110 
        
           if (isinstance(value, bytes) and 
        
               guessed_type == type_pb2.Type(code=type_pb2.BYTES)): 
        
             encoded_value = base64.b64encode(value).decode() 
        
           elif (isinstance(value, (list, tuple)) and 
        
                 all(isinstance(x, bytes) for x in value if x is not None) and 
        
                 guessed_type == type_pb2.Type( 
        
                     code=type_pb2.ARRAY, 
        
                     array_element_type=type_pb2.Type(code=type_pb2.BYTES), 
        
                 )): 
        
             encoded_value = tuple( 
        
                 None if item is None else base64.b64encode(item).decode() 
        
                 for item in value)

I'm not sure if any of that code would be useful or not for supporting bytes fields though.

	# BYTES must be base64-encoded, see
	# https://github.com/googleapis/python-spanner/blob/87789c939990794bfd91f5300bedc449fd74bd7e/google/cloud/spanner_v1/proto/type.proto#L108-L110
	if (isinstance(value, bytes) and
	guessed_type == type_pb2.Type(code=type_pb2.BYTES)):
	encoded_value = base64.b64encode(value).decode()
	elif (isinstance(value, (list, tuple)) and
	all(isinstance(x, bytes) for x in value if x is not None) and
	guessed_type == type_pb2.Type(
	code=type_pb2.ARRAY,
	array_element_type=type_pb2.Type(code=type_pb2.BYTES),
	)):
	encoded_value = tuple(
	None if item is None else base64.b64encode(item).decode()
	for item in value)

BYTES support for field type #149

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions