From bb58f2611469851d842f95a65da1bf926c0c85c3 Mon Sep 17 00:00:00 2001 From: bradleydamato Date: Fri, 2 Oct 2020 13:32:27 -0400 Subject: [PATCH 1/3] Converting to on line 311 of completion.py --- fire/completion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fire/completion.py b/fire/completion.py index 2c9f15c0..ee868b62 100644 --- a/fire/completion.py +++ b/fire/completion.py @@ -308,7 +308,7 @@ def MemberVisible(component, name, member, class_attrs=None, verbose=False): return False if verbose: return True - if member in (absolute_import, division, print_function): + if type(member) in (absolute_import, division, print_function): return False if isinstance(member, type(absolute_import)) and six.PY34: return False From ebc446fa79702ce532fb2e0355b69335e6ef027a Mon Sep 17 00:00:00 2001 From: bradleydamato Date: Fri, 2 Oct 2020 13:53:55 -0400 Subject: [PATCH 2/3] Fixing according to @dbieber's advice in PR #290 comments --- fire/completion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fire/completion.py b/fire/completion.py index ee868b62..022cd172 100644 --- a/fire/completion.py +++ b/fire/completion.py @@ -308,7 +308,7 @@ def MemberVisible(component, name, member, class_attrs=None, verbose=False): return False if verbose: return True - if type(member) in (absolute_import, division, print_function): + if (member is absolute_import or member is division or member is print_function): return False if isinstance(member, type(absolute_import)) and six.PY34: return False From 98b131f15d2f9540628942f975699a00a89d0c87 Mon Sep 17 00:00:00 2001 From: bradleydamato Date: Fri, 2 Oct 2020 14:02:29 -0400 Subject: [PATCH 3/3] Fixing line-length issue from Travis on line 311 --- fire/completion.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fire/completion.py b/fire/completion.py index 022cd172..cd9f2698 100644 --- a/fire/completion.py +++ b/fire/completion.py @@ -308,7 +308,9 @@ def MemberVisible(component, name, member, class_attrs=None, verbose=False): return False if verbose: return True - if (member is absolute_import or member is division or member is print_function): + if (member is absolute_import\ + or member is division\ + or member is print_function): return False if isinstance(member, type(absolute_import)) and six.PY34: return False