Skip to content

ASTHelpersSuggestions does not flag call to packge() on com.sun.tools.javac.code.Symbol.ClassSymbol #3482

New issue
New issue
Closed
Closed
ASTHelpersSuggestions does not flag call to packge() on com.sun.tools.javac.code.Symbol.ClassSymbol#3482

Description

@msridhar
msridhar
opened on Oct 12, 2022

I noticed that calls to packge() were not flagged by the new ASTHelpersSuggestions check when the static type of the receiver is com.sun.tools.javac.code.Symbol.ClassSymbol, which just inherits the packge() method from Symbol. I think this is because the check matches on the exact class Symbol:

error-prone/core/src/main/java/com/google/errorprone/bugpatterns/ASTHelpersSuggestions.java

Lines 43 to 46 in 80650f5

private static final Matcher<ExpressionTree> SYMBOL =
instanceMethod()
.onExactClass("com.sun.tools.javac.code.Symbol")
.namedAnyOf("isDirectlyOrIndirectlyLocal", "isLocal", "packge", "isStatic");

Was this intentional?

Activity

  1. graememorgan commented on Oct 17, 2022

    @graememorgan
    graememorgan
    on Oct 17, 2022
    Contributor

    I've sent a PR to fix this internally, so I'll optimistically mark this as fixed in the next release.

  2. graememorgan
    closed this as completedon Oct 17, 2022
  3. copybara-service
    added 2 commits that reference this issue on Oct 18, 2022

    Have ASTHelpersSuggestions handle subtypes of Symbol too.

    5646cf4

    Have ASTHelpersSuggestions handle subtypes of Symbol too.

    081f67e
  4. benkard
    added a commit that references this issue on Jan 14, 2023

    Update all non-major dependencies (mulk/jgvariant!22)

    d1cd814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions