Fix some crashes in warning-level checks

cushon · Error Prone Team · commit ca2e11db39a9 · 2025-06-23T09:38:45.000-07:00
PiperOrigin-RevId: 774814165
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/BooleanLiteral.java b/core/src/main/java/com/google/errorprone/bugpatterns/BooleanLiteral.java
@@ -52,7 +52,7 @@ public Description matchMemberSelect(MemberSelectTree tree, VisitorState state)
 
   private Description match(ExpressionTree tree, VisitorState state) {
     Symbol sym = getSymbol(tree);
-    if (sym == null) {
+    if (sym == null || sym.owner == null) {
       return NO_MATCH;
     }
     if (!sym.owner.equals(state.getTypes().boxedClass(state.getSymtab().booleanType))) {
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryParentheses.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryParentheses.java
@@ -19,6 +19,7 @@
 import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
 import static com.google.errorprone.matchers.Description.NO_MATCH;
 import static com.google.errorprone.util.ASTHelpers.getStartPosition;
+import static com.google.errorprone.util.ASTHelpers.hasExplicitSource;
 
 import com.google.errorprone.BugPattern;
 import com.google.errorprone.VisitorState;
@@ -43,6 +44,9 @@ public class UnnecessaryParentheses extends BugChecker
 
   @Override
   public Description matchAnnotation(AnnotationTree tree, VisitorState state) {
+    if (!hasExplicitSource(tree, state)) {
+      return NO_MATCH;
+    }
     return state.getSourceForNode(tree).endsWith("()")
         ? describeMatch(
             tree,
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BooleanLiteralTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BooleanLiteralTest.java
@@ -77,4 +77,18 @@ void f() {
         .expectUnchanged()
         .doTest();
   }
+
+  @Test
+  public void moduleInfo() {
+    refactoringHelper
+        .addInputLines(
+            "module-info.java",
+            """
+            module foo {
+              requires java.base;
+            }
+            """)
+        .expectUnchanged()
+        .doTest();
+  }
 }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryParenthesesTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryParenthesesTest.java
@@ -16,6 +16,7 @@
 
 package com.google.errorprone.bugpatterns;
 
+import com.google.auto.value.processor.AutoValueProcessor;
 import com.google.errorprone.BugCheckerRefactoringTestHelper;
 import com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode;
 import com.google.errorprone.CompilationTestHelper;
@@ -369,4 +370,31 @@ public String toString() {
         // Using TEXT_MATCH because the ASTs are the same with or without the parentheses!
         .doTest(TestMode.TEXT_MATCH);
   }
+
+  @Test
+  public void recordParameters() {
+    testHelper
+        .addInputLines(
+            "R.java",
+            """
+            import org.checkerframework.checker.nullness.qual.Nullable;
+            import org.checkerframework.dataflow.qual.Pure;
+            import com.google.auto.value.AutoBuilder;
+
+            /**
+             * A record with parameters.
+             *
+             * @param x parameter x
+             * @param y parameter y
+             * @param z parameter z
+             */
+            public record R(@Pure boolean x, @Pure @Nullable String y, @Pure @Nullable String z) {
+              @AutoBuilder
+              public abstract static class Builder {}
+            }
+            """)
+        .expectUnchanged()
+        .setArgs("-processor", AutoValueProcessor.class.getName())
+        .doTest(TestMode.TEXT_MATCH);
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public Description matchMemberSelect(MemberSelectTree tree, VisitorState state)`
`52`	`52`
`53`	`53`	`private Description match(ExpressionTree tree, VisitorState state) {`
`54`	`54`	`Symbol sym = getSymbol(tree);`
`55`		`- if (sym == null) {`
	`55`	`+ if (sym == null \|\| sym.owner == null) {`
`56`	`56`	`return NO_MATCH;`
`57`	`57`	`}`
`58`	`58`	`if (!sym.owner.equals(state.getTypes().boxedClass(state.getSymtab().booleanType))) {`