Issue #4213: The file system encoding is now normalized by the codec subsystem, for example UTF-8 is turned into utf-8.

christian.heimes · christian.heimes · commit 2b32aa754e20 · 2008-10-30T21:40:04.000Z
Patch created by Victor and reviewed by me. The change is required for proper initialization of subinterpreters. git-svn-id: http://svn.python.org/projects/python/branches/py3k@67055 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -15,6 +15,9 @@ What's New in Python 3.0 beta 5
 Core and Builtins
 -----------------
 
+- Issue #4213: The file system encoding is now normalized by the
+  codec subsystem, for example UTF-8 is turned into utf-8.
+
 - Issue #4200: Changed the atexit module to store its state in its
   PyModuleDef atexitmodule. This fixes a bug with multiple subinterpeters.
 
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -126,6 +126,37 @@ add_flag(int flag, const char *envs)
 	return flag;
 }
 
+#if defined(HAVE_LANGINFO_H) && defined(CODESET)
+static char*
+get_codeset(void)
+{
+	char* codeset;
+	PyObject *codec, *name;
+
+	codeset = nl_langinfo(CODESET);
+	if (!codeset || codeset[0] == '\0')
+		return NULL;
+
+	codec = _PyCodec_Lookup(codeset);
+	if (!codec)
+		goto error;
+
+	name = PyObject_GetAttrString(codec, "name");
+	Py_CLEAR(codec);
+	if (!name)
+		goto error;
+
+	codeset = strdup(_PyUnicode_AsString(name));
+	Py_DECREF(name);
+	return codeset;
+
+error:
+	Py_XDECREF(codec);
+	PyErr_Clear();
+	return NULL;
+}
+#endif
+
 void
 Py_InitializeEx(int install_sigs)
 {
@@ -257,15 +288,7 @@ Py_InitializeEx(int install_sigs)
 	   initialized by other means. Also set the encoding of
 	   stdin and stdout if these are terminals.  */
 
-	codeset = nl_langinfo(CODESET);
-	if (codeset && *codeset) {
-	    if (PyCodec_KnownEncoding(codeset))
-		codeset = strdup(codeset);
-	    else
-		codeset = NULL;
-	} else
-		codeset = NULL;
-
+	codeset = get_codeset();
 	if (codeset) {
 		if (!Py_FileSystemDefaultEncoding)
 			Py_FileSystemDefaultEncoding = codeset;
