Fix Coverity warnings.

neal.norwitz · neal.norwitz · commit 1d0aeb638523 · 2006-05-27T05:21:30.000Z
- Check the correct variable (str_obj, not str) for NULL - sep_len was already verified it wasn't 0 git-svn-id: http://svn.python.org/projects/python/trunk@46431 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Objects/stringlib/partition.h b/Objects/stringlib/partition.h
@@ -58,7 +58,7 @@ stringlib_rpartition(
     )
 {
     PyObject* out;
-    Py_ssize_t pos;
+    Py_ssize_t pos, j;
 
     if (sep_len == 0) {
         PyErr_SetString(PyExc_ValueError, "empty separator");
@@ -70,17 +70,12 @@ stringlib_rpartition(
 	return NULL;
 
     /* XXX - create reversefastsearch helper! */
-    if (sep_len == 0)
-	pos = str_len;
-    else {
-	Py_ssize_t j;
         pos = -1;
 	for (j = str_len - sep_len; j >= 0; --j)
             if (STRINGLIB_CMP(str+j, sep, sep_len) == 0) {
                 pos = j;
                 break;
             }
-    }
 
     if (pos < 0) {
 	Py_INCREF(str_obj);
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -3955,7 +3955,7 @@ Py_ssize_t PyUnicode_Find(PyObject *str,
     PyUnicodeObject* sub_obj;
 
     str_obj = (PyUnicodeObject*) PyUnicode_FromObject(str);
-    if (!str)
+    if (!str_obj)
 	return -2;
     sub_obj = (PyUnicodeObject*) PyUnicode_FromObject(substr);
     if (!sub_obj) {
