Fix Rubocop offenses

ZoeLeBlanc · ZoeLeBlanc · commit 07495d886dba · 2026-03-29T11:55:36.000-05:00
diff --git a/lib/html_proofer/runner.rb b/lib/html_proofer/runner.rb
@@ -200,7 +200,7 @@ def checks
     end
 
     def failed_checks
-      @reporter.failures.flatten.select { |f| f.is_a?(Failure) }
+      @reporter.failures.flatten.grep(Failure)
     end
 
     def report_failed_checks
diff --git a/lib/html_proofer/url_validator/internal.rb b/lib/html_proofer/url_validator/internal.rb
@@ -118,10 +118,10 @@ def run_internal_link_checker(links)
 
         # For hash links, we need to defer to file-based checking
         # (even if URL doesn't have extension, it may resolve to index.html)
-        return nil unless url.has_hash?
+        return unless url.has_hash? # rubocop:disable Style/ReturnNilInPredicateMethodDefinition
 
         # If URL has no known extension, defer to file-based checking
-        return nil unless url.known_extension?
+        return unless url.known_extension? # rubocop:disable Style/ReturnNilInPredicateMethodDefinition
 
         decoded_href_hash = Addressable::URI.unescape(href_hash)
         fragment_ids = [href_hash, decoded_href_hash]
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -70,7 +70,6 @@ def capture_proofer_http(item, type, opts = {})
 end
 
 def make_bin(args)
-  ap("#{RbConfig.ruby} exe/htmlproofer #{args}") if debug?
   stdout, stderr = Open3.capture3("#{RbConfig.ruby} exe/htmlproofer #{args}")
   # Filter out Ruby experimental warnings (e.g., IO::Buffer in Ruby 4.0)
   stderr = stderr.lines.reject { |line| line.include?("warning:") && line.include?("experimental") }.join
