CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1

John Kinsella · ke4qqq · commit efe318336abb · 2012-05-27T19:39:56.000-04:00
Description:
Unindented 3 lines to update logic flow to execute iptables when
passed ICMP type is not -1.
diff --git a/scripts/vm/network/security_group.py b/scripts/vm/network/security_group.py
@@ -639,8 +639,8 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
                 range = start + "/" + end
                 if start == "-1":
                     range = "any"
-                    for ip in ips:
-                        execute("iptables -I " + vmchain + " -p icmp --icmp-type " + range + " " + direction + "  " + ip + " -j "+ action)
+                for ip in ips:
+                    execute("iptables -I " + vmchain + " -p icmp --icmp-type " + range + " " + direction + "  " + ip + " -j "+ action)
         
         if allow_any and protocol != 'all':
             if protocol != 'icmp':
@@ -649,7 +649,7 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
                 range = start + "/" + end
                 if start == "-1":
                     range = "any"
-                    execute("iptables -I " + vmchain + " -p icmp --icmp-type " + range + " -j "+action)
+                execute("iptables -I " + vmchain + " -p icmp --icmp-type " + range + " -j "+action)
  
     egress_vmchain = egress_chain_name(vm_name)
     if egressrule == 0 :
