Skip to content

Commit efab2f4

Browse files
author
Alena Prokharchyk
committed
Removed more unused imports in Snapshots code
Conflicts: server/src/com/cloud/storage/dao/SnapshotScheduleDao.java server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java
1 parent c27b44e commit efab2f4

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

server/src/com/cloud/network/rules/RulesManagerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,11 @@ public PortForwardingRule createPortForwardingRule(PortForwardingRule rule, Long
255255
if (validatePortRange) {
256256
//source start port and source dest port should be the same. The same applies to dest ports
257257
if (rule.getSourcePortStart().intValue() != rule.getDestinationPortStart()) {
258-
throw new InvalidParameterValueException("Private port start should be equal to public port start", null);
258+
throw new InvalidParameterValueException("Private port start should be equal to public port start");
259259
}
260260

261261
if (rule.getSourcePortEnd().intValue() != rule.getDestinationPortEnd()) {
262-
throw new InvalidParameterValueException("Private port end should be equal to public port end", null);
262+
throw new InvalidParameterValueException("Private port end should be equal to public port end");
263263
}
264264
}
265265

server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import com.cloud.api.ApiDispatcher;
3232
import com.cloud.api.ApiGsonHelper;
3333
import com.cloud.api.commands.CreateSnapshotCmd;
34+
import com.cloud.user.Account;
3435
import com.cloud.async.AsyncJobManager;
3536
import com.cloud.async.AsyncJobResult;
3637
import com.cloud.async.AsyncJobVO;
@@ -46,9 +47,7 @@
4647
import com.cloud.storage.dao.SnapshotDao;
4748
import com.cloud.storage.dao.SnapshotPolicyDao;
4849
import com.cloud.storage.dao.SnapshotScheduleDao;
49-
import com.cloud.storage.dao.StoragePoolHostDao;
5050
import com.cloud.storage.dao.VolumeDao;
51-
import com.cloud.user.Account;
5251
import com.cloud.user.User;
5352
import com.cloud.utils.DateUtil;
5453
import com.cloud.utils.DateUtil.IntervalType;
@@ -60,9 +59,7 @@
6059
import com.cloud.utils.db.GlobalLock;
6160
import com.cloud.utils.db.SearchCriteria;
6261

63-
/**
64-
*
65-
*/
62+
6663
@Local(value={SnapshotScheduler.class})
6764
public class SnapshotSchedulerImpl implements SnapshotScheduler {
6865
private static final Logger s_logger = Logger.getLogger(SnapshotSchedulerImpl.class);
@@ -73,8 +70,6 @@ public class SnapshotSchedulerImpl implements SnapshotScheduler {
7370
@Inject protected SnapshotScheduleDao _snapshotScheduleDao;
7471
@Inject protected SnapshotPolicyDao _snapshotPolicyDao;
7572
@Inject protected AsyncJobManager _asyncMgr;
76-
@Inject protected SnapshotManager _snapshotManager;
77-
@Inject protected StoragePoolHostDao _poolHostDao;
7873
@Inject protected VolumeDao _volsDao;
7974

8075
private static final int ACQUIRE_GLOBAL_LOCK_TIMEOUT_FOR_COOPERATION = 5; // 5 seconds

0 commit comments

Comments
 (0)