Summary: Fix NPE when calling createFirewallRule

Marcus Sorensen · Marcus Sorensen · commit ec6fdc7471a3 · 2013-02-06T10:15:16.000-07:00
Detail: CreateFirewallRuleCmd.java was returning 'null' for getTrafficType().
Recently, getTrafficType started being used by createIngressFirewallRule.
Changing getTrafficType() to return ingress per Jayapal Reddy.

BUG-ID: CLOUDSTACK-1168
Bugfix-for: master,4.1
Signed-off-by: Marcus Sorensen &lt;marcus@betterservers.com&gt; 1360170916 -0700
diff --git a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
@@ -324,7 +324,7 @@ public AsyncJob.Type getInstanceType() {
 
     @Override
     public TrafficType getTrafficType() {
-        return null;
+        return FirewallRule.TrafficType.Ingress;
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ public AsyncJob.Type getInstanceType() {`
`324`	`324`
`325`	`325`	`@Override`
`326`	`326`	`public TrafficType getTrafficType() {`
`327`		`- return null;`
	`327`	`+ return FirewallRule.TrafficType.Ingress;`
`328`	`328`	`}`
`329`	`329`
`330`	`330`	`}`