Detail view: Cleanup old tab content on change

bfederle · bfederle · commit cd17061916ea · 2014-06-12T13:33:21.000-07:00
Add event handler on tab change to remove all old tab content. This prevents
potential conflicts with referencing widget data caused by old content laying
around.
diff --git a/ui/scripts/ui/widgets/detailView.js b/ui/scripts/ui/widgets/detailView.js
@@ -1465,7 +1465,12 @@
             }
         }
 
-        $detailView.tabs();
+        $detailView.tabs({
+            select: function() {
+                // Cleanup old tab content
+                $detailView.find('.detail-group').children().remove();
+            }
+        });
 
         return $detailView;
     };

Original file line number	Diff line number	Diff line change
`@@ -1465,7 +1465,12 @@`
`1465`	`1465`	`}`
`1466`	`1466`	`}`
`1467`	`1467`
`1468`		`- $detailView.tabs();`
	`1468`	`+ $detailView.tabs({`
	`1469`	`+ select: function() {`
	`1470`	`+ // Cleanup old tab content`
	`1471`	`+ $detailView.find('.detail-group').children().remove();`
	`1472`	`+ }`
	`1473`	`+ });`
`1469`	`1474`
`1470`	`1475`	`return $detailView;`
`1471`	`1476`	`};`