Skip to content

Commit bd1ddee

Browse files
committed
UI: Localize app name and 'about' window
1 parent d660bc7 commit bd1ddee

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

client/WEB-INF/classes/resources/messages.properties

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
# KIND, either express or implied. See the License for the
1515
# specific language governing permissions and limitations
1616
# under the License.
17+
label.about=About
18+
label.app.name=CloudStack
19+
label.about.app=About CloudStack
1720
label.custom.disk.iops=Custom IOPS
1821
label.disk.iops.min=Min IOPS
1922
label.disk.iops.max=Max IOPS

ui/dictionary.jsp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ under the License.
2525
<% long now = System.currentTimeMillis(); %>
2626
<script language="javascript">
2727
dictionary = {
28+
'label.about': '<fmt:message key="label.about" />',
29+
'label.about.app': '<fmt:message key="label.about.app" />',
30+
'label.app.name': '<fmt:message key="label.app.name" />',
2831
'label.custom.disk.iops': '<fmt:message key="label.custom.disk.iops" />',
2932
'label.disk.iops.min': '<fmt:message key="label.disk.iops.min" />',
3033
'label.disk.iops.max': '<fmt:message key="label.disk.iops.max" />',

ui/scripts/cloudStack.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,6 @@
475475
};
476476
}
477477
};
478-
479-
document.title = 'CloudStack';
480478

481479
if ($.urlParam('loginUrl') != 0
482480
||(window.name != null && window.name.indexOf("&domain=") != -1)) {
@@ -490,5 +488,7 @@
490488
cloudStack.localizationFn = function(str) {
491489
return dictionary[str];
492490
};
491+
492+
document.title = _l('label.app.name');
493493
});
494494
})(cloudStack, jQuery);

ui/scripts/ui/core.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@
275275
var $options = $('<div>').attr({ id: 'user-options' })
276276
.appendTo($('#header'));
277277

278-
$(['label.logout', 'label.help', 'About']).each(function() {
278+
$(['label.logout', 'label.help', 'label.about']).each(function() {
279279
var $link = $('<a>')
280280
.attr({ href: '#' })
281281
.html(_l(this.toString()))
@@ -290,15 +290,15 @@
290290
return false;
291291
});
292292
}
293-
if (this == 'About') {
293+
if (this == 'label.about') {
294294
$link.click(function() {
295-
var $logo = $('<div>').addClass('logo').html('CloudStack'),
295+
var $logo = $('<div>').addClass('logo').html(_l('label.app.name')),
296296
$version = $('<div>').addClass('version').html(g_cloudstackversion),
297297
$about = $('<div>').addClass('about').append($logo).append($version);
298298
$about.dialog({
299299
modal: true,
300300
width: 300,
301-
title: 'About CloudStack',
301+
title: _l('label.about.app'),
302302
closeOnEscape: false,
303303
dialogClass: 'dialog-about',
304304
buttons: {

0 commit comments

Comments
 (0)