api: Fix method name findByXId to findByUuid

yadvr · yadvr · commit ba5fba939c1a · 2012-12-18T17:44:17.000-08:00
- findByXId is read as find using some external Id (used by external network devices for ex.)
- what we really need is findByUuid that finds a unique VO using a uuid string

Signed-off-by: Rohit Yadav &lt;bhaisaab@apache.org&gt;
diff --git a/utils/src/com/cloud/utils/db/GenericDao.java b/utils/src/com/cloud/utils/db/GenericDao.java
@@ -55,8 +55,8 @@ public interface GenericDao<T, ID extends Serializable> {
     
     T findById(ID id, boolean fresh);
 
-    // Finds a VO object using uuid
-    T findByXId(ID uuid);
+    // Finds one unique VO using uuid
+    T findByUuid(ID uuid);
     
     /**
      * @return VO object ready to be used for update.  It won't have any fields filled in.
diff --git a/utils/src/com/cloud/utils/db/GenericDaoBase.java b/utils/src/com/cloud/utils/db/GenericDaoBase.java
@@ -915,7 +915,7 @@ public T findById(final ID id) {
 
     @Override @DB(txn=false)
     @SuppressWarnings("unchecked")
-    public T findByXId(final ID uuid) {
+    public T findByUuid(final ID uuid) {
         SearchCriteria<T> sc = createSearchCriteria();
         sc.addAnd("uuid", SearchCriteria.Op.EQ, uuid);
         return findOneBy(sc);
