Skip to content

Commit a964cf5

Browse files
author
Alex Huang
committed
Continue to merge SearchCriteria2 and GenericSearchBuilder
1 parent af8832f commit a964cf5

36 files changed

Lines changed: 461 additions & 310 deletions

engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineClusterDaoImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ public Map<Long, List<Long>> getPodClusterIdMap(List<Long> clusterIds){
202202
@Override
203203
public List<Long> listDisabledClusters(long zoneId, Long podId) {
204204
GenericSearchBuilder<EngineClusterVO, Long> clusterIdSearch = createSearchBuilder(Long.class);
205-
clusterIdSearch.selectField(clusterIdSearch.entity().getId());
205+
clusterIdSearch.selectFields(clusterIdSearch.entity().getId());
206206
clusterIdSearch.and("dataCenterId", clusterIdSearch.entity().getDataCenterId(), Op.EQ);
207207
if(podId != null){
208208
clusterIdSearch.and("podId", clusterIdSearch.entity().getPodId(), Op.EQ);
@@ -224,12 +224,12 @@ public List<Long> listDisabledClusters(long zoneId, Long podId) {
224224
public List<Long> listClustersWithDisabledPods(long zoneId) {
225225

226226
GenericSearchBuilder<EngineHostPodVO, Long> disabledPodIdSearch = _hostPodDao.createSearchBuilder(Long.class);
227-
disabledPodIdSearch.selectField(disabledPodIdSearch.entity().getId());
227+
disabledPodIdSearch.selectFields(disabledPodIdSearch.entity().getId());
228228
disabledPodIdSearch.and("dataCenterId", disabledPodIdSearch.entity().getDataCenterId(), Op.EQ);
229229
disabledPodIdSearch.and("allocationState", disabledPodIdSearch.entity().getAllocationState(), Op.EQ);
230230

231231
GenericSearchBuilder<EngineClusterVO, Long> clusterIdSearch = createSearchBuilder(Long.class);
232-
clusterIdSearch.selectField(clusterIdSearch.entity().getId());
232+
clusterIdSearch.selectFields(clusterIdSearch.entity().getId());
233233
clusterIdSearch.join("disabledPodIdSearch", disabledPodIdSearch, clusterIdSearch.entity().getPodId(), disabledPodIdSearch.entity().getId(), JoinBuilder.JoinType.INNER);
234234
clusterIdSearch.done();
235235

engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public EngineHostDaoImpl() {
269269
AvailHypevisorInZone.done();
270270

271271
HostsInStatusSearch = createSearchBuilder(Long.class);
272-
HostsInStatusSearch.selectField(HostsInStatusSearch.entity().getId());
272+
HostsInStatusSearch.selectFields(HostsInStatusSearch.entity().getId());
273273
HostsInStatusSearch.and("dc", HostsInStatusSearch.entity().getDataCenterId(), Op.EQ);
274274
HostsInStatusSearch.and("pod", HostsInStatusSearch.entity().getPodId(), Op.EQ);
275275
HostsInStatusSearch.and("cluster", HostsInStatusSearch.entity().getClusterId(), Op.EQ);

engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/dao/EngineHostPodDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public boolean remove(Long id) {
138138
@Override
139139
public List<Long> listDisabledPods(long zoneId) {
140140
GenericSearchBuilder<EngineHostPodVO, Long> podIdSearch = createSearchBuilder(Long.class);
141-
podIdSearch.selectField(podIdSearch.entity().getId());
141+
podIdSearch.selectFields(podIdSearch.entity().getId());
142142
podIdSearch.and("dataCenterId", podIdSearch.entity().getDataCenterId(), Op.EQ);
143143
podIdSearch.and("allocationState", podIdSearch.entity().getAllocationState(), Op.EQ);
144144
podIdSearch.done();

engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public ClusterDaoImpl() {
9494
ZoneClusterSearch.done();
9595

9696
ClusterIdSearch = createSearchBuilder(Long.class);
97-
ClusterIdSearch.selectField(ClusterIdSearch.entity().getId());
97+
ClusterIdSearch.selectFields(ClusterIdSearch.entity().getId());
9898
ClusterIdSearch.and("dataCenterId", ClusterIdSearch.entity().getDataCenterId(), Op.EQ);
9999
ClusterIdSearch.done();
100100
}
@@ -196,7 +196,7 @@ public Map<Long, List<Long>> getPodClusterIdMap(List<Long> clusterIds){
196196
@Override
197197
public List<Long> listDisabledClusters(long zoneId, Long podId) {
198198
GenericSearchBuilder<ClusterVO, Long> clusterIdSearch = createSearchBuilder(Long.class);
199-
clusterIdSearch.selectField(clusterIdSearch.entity().getId());
199+
clusterIdSearch.selectFields(clusterIdSearch.entity().getId());
200200
clusterIdSearch.and("dataCenterId", clusterIdSearch.entity().getDataCenterId(), Op.EQ);
201201
if (podId != null) {
202202
clusterIdSearch.and("podId", clusterIdSearch.entity().getPodId(), Op.EQ);
@@ -217,12 +217,12 @@ public List<Long> listDisabledClusters(long zoneId, Long podId) {
217217
public List<Long> listClustersWithDisabledPods(long zoneId) {
218218

219219
GenericSearchBuilder<HostPodVO, Long> disabledPodIdSearch = _hostPodDao.createSearchBuilder(Long.class);
220-
disabledPodIdSearch.selectField(disabledPodIdSearch.entity().getId());
220+
disabledPodIdSearch.selectFields(disabledPodIdSearch.entity().getId());
221221
disabledPodIdSearch.and("dataCenterId", disabledPodIdSearch.entity().getDataCenterId(), Op.EQ);
222222
disabledPodIdSearch.and("allocationState", disabledPodIdSearch.entity().getAllocationState(), Op.EQ);
223223

224224
GenericSearchBuilder<ClusterVO, Long> clusterIdSearch = createSearchBuilder(Long.class);
225-
clusterIdSearch.selectField(clusterIdSearch.entity().getId());
225+
clusterIdSearch.selectFields(clusterIdSearch.entity().getId());
226226
clusterIdSearch.join("disabledPodIdSearch", disabledPodIdSearch, clusterIdSearch.entity().getPodId(), disabledPodIdSearch.entity().getId(), JoinBuilder.JoinType.INNER);
227227
clusterIdSearch.done();
228228

engine/schema/src/com/cloud/dc/dao/HostPodDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public HostPodDaoImpl() {
5757
DataCenterIdSearch.done();
5858

5959
PodIdSearch = createSearchBuilder(Long.class);
60-
PodIdSearch.selectField(PodIdSearch.entity().getId());
60+
PodIdSearch.selectFields(PodIdSearch.entity().getId());
6161
PodIdSearch.and("dataCenterId", PodIdSearch.entity().getDataCenterId(), Op.EQ);
6262
PodIdSearch.and("allocationState", PodIdSearch.entity().getAllocationState(), Op.EQ);
6363
PodIdSearch.done();

engine/schema/src/com/cloud/dc/dao/StorageNetworkIpAddressDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected StorageNetworkIpAddressDaoImpl() {
5656
countInUserIp.done();
5757

5858
listInUseIp = createSearchBuilder(String.class);
59-
listInUseIp.selectField(listInUseIp.entity().getIpAddress());
59+
listInUseIp.selectFields(listInUseIp.entity().getIpAddress());
6060
listInUseIp.and("rangeId", listInUseIp.entity().getRangeId(), Op.EQ);
6161
listInUseIp.and("taken", listInUseIp.entity().getTakenAt(), Op.NNULL);
6262
listInUseIp.done();

engine/schema/src/com/cloud/domain/dao/DomainDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public DomainDaoImpl () {
7474
FindAllChildrenSearch.done();
7575

7676
FindIdsOfAllChildrenSearch = createSearchBuilder(Long.class);
77-
FindIdsOfAllChildrenSearch.selectField(FindIdsOfAllChildrenSearch.entity().getId());
77+
FindIdsOfAllChildrenSearch.selectFields(FindIdsOfAllChildrenSearch.entity().getId());
7878
FindIdsOfAllChildrenSearch.and("path", FindIdsOfAllChildrenSearch.entity().getPath(), SearchCriteria.Op.LIKE);
7979
FindIdsOfAllChildrenSearch.done();
8080

engine/schema/src/com/cloud/host/dao/HostDaoImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ public void init() {
306306
AvailHypevisorInZone.done();
307307

308308
HostsInStatusSearch = createSearchBuilder(Long.class);
309-
HostsInStatusSearch.selectField(HostsInStatusSearch.entity().getId());
309+
HostsInStatusSearch.selectFields(HostsInStatusSearch.entity().getId());
310310
HostsInStatusSearch.and("dc", HostsInStatusSearch.entity().getDataCenterId(), Op.EQ);
311311
HostsInStatusSearch.and("pod", HostsInStatusSearch.entity().getPodId(), Op.EQ);
312312
HostsInStatusSearch.and("cluster", HostsInStatusSearch.entity().getClusterId(), Op.EQ);
@@ -370,7 +370,7 @@ public void init() {
370370
HostsInClusterSearch.done();
371371

372372
HostIdSearch = createSearchBuilder(Long.class);
373-
HostIdSearch.selectField(HostIdSearch.entity().getId());
373+
HostIdSearch.selectFields(HostIdSearch.entity().getId());
374374
HostIdSearch.and("dataCenterId", HostIdSearch.entity().getDataCenterId(), Op.EQ);
375375
HostIdSearch.done();
376376

engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ protected void init() {
226226
OfferingAccountNetworkSearch.done();
227227

228228
GarbageCollectedSearch = createSearchBuilder(Long.class);
229-
GarbageCollectedSearch.selectField(GarbageCollectedSearch.entity().getId());
229+
GarbageCollectedSearch.selectFields(GarbageCollectedSearch.entity().getId());
230230
SearchBuilder<NetworkOpVO> join7 = _ntwkOpDao.createSearchBuilder();
231231
join7.and("activenics", join7.entity().getActiveNicsCount(), Op.EQ);
232232
join7.and("gc", join7.entity().isGarbageCollected(), Op.EQ);

engine/schema/src/com/cloud/network/dao/NetworkOpDaoImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ protected NetworkOpDaoImpl() {
3939
super();
4040

4141
ActiveNicsSearch = createSearchBuilder(Integer.class);
42-
ActiveNicsSearch.selectField(ActiveNicsSearch.entity().getActiveNicsCount());
42+
ActiveNicsSearch.selectFields(ActiveNicsSearch.entity().getActiveNicsCount());
4343
ActiveNicsSearch.and("network", ActiveNicsSearch.entity().getId(), Op.EQ);
4444
ActiveNicsSearch.done();
4545

0 commit comments

Comments
 (0)