CLOUDSTACK-2087: Destroying the instance is not decrementing the primary storage usage [Resource Count table - No of volumes is not got decremented]

sanjaytripathi · Sateesh Chodapuneedi · commit 85a1cc962cb3 · 2013-05-02T16:17:13.000+05:30
Signed-off-by: Sateesh Chodapuneedi &lt;sateesh@apache.org&gt;
diff --git a/server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b/server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
@@ -582,7 +582,7 @@ public ResourceLimitVO updateResourceLimit(Long accountId, Long domainId, Intege
         }
 
         //Convert max storage size from GiB to bytes
-        if (resourceType == ResourceType.primary_storage || resourceType == ResourceType.secondary_storage) {
+        if ((resourceType == ResourceType.primary_storage || resourceType == ResourceType.secondary_storage) && max >= 0) {
             max = max * ResourceType.bytesToGiB;
         }
 
diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -64,6 +64,7 @@
 import com.cloud.cluster.ClusterManager;
 import com.cloud.configuration.Config;
 import com.cloud.configuration.ConfigurationManager;
+import com.cloud.configuration.Resource.ResourceType;
 import com.cloud.configuration.dao.ConfigurationDao;
 import com.cloud.dc.dao.ClusterDao;
 import com.cloud.dc.DataCenter;
@@ -131,6 +132,7 @@
 import com.cloud.storage.snapshot.SnapshotManager;
 import com.cloud.user.Account;
 import com.cloud.user.AccountManager;
+import com.cloud.user.ResourceLimitService;
 import com.cloud.user.User;
 import com.cloud.user.dao.AccountDao;
 import com.cloud.user.dao.UserDao;
@@ -231,6 +233,8 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac
     protected VMSnapshotDao _vmSnapshotDao;
     @Inject
     protected VolumeDataFactory volFactory;
+    @Inject
+    protected ResourceLimitService _resourceLimitMgr;
 
     protected List<DeploymentPlanner> _planners;
     public List<DeploymentPlanner> getPlanners() {
@@ -428,6 +432,7 @@ public <T extends VMInstanceVO> boolean advanceExpunge(T vm, User caller, Accoun
         s_logger.debug("Cleaning up NICS");
         _networkMgr.cleanupNics(profile);
         // Clean up volumes based on the vm's instance id
+        List<VolumeVO> rootVol = _volsDao.findByInstanceAndType(vm.getId(), Volume.Type.ROOT);
         this.volumeMgr.cleanupVolumes(vm.getId());
 
         VirtualMachineGuru<T> guru = getVmGuru(vm);
@@ -462,6 +467,12 @@ public <T extends VMInstanceVO> boolean advanceExpunge(T vm, User caller, Accoun
             s_logger.debug("Expunged " + vm);
         }
 
+        // Update Resource count
+        if (vm.getAccountId() != Account.ACCOUNT_ID_SYSTEM && !rootVol.isEmpty()) {
+            _resourceLimitMgr.decrementResourceCount(vm.getAccountId(), ResourceType.volume);
+            _resourceLimitMgr.decrementResourceCount(vm.getAccountId(), ResourceType.primary_storage,
+                    new Long(rootVol.get(0).getSize()));
+        }
         return true;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -582,7 +582,7 @@ public ResourceLimitVO updateResourceLimit(Long accountId, Long domainId, Intege`
`582`	`582`	`}`
`583`	`583`
`584`	`584`	`//Convert max storage size from GiB to bytes`
`585`		`- if (resourceType == ResourceType.primary_storage \|\| resourceType == ResourceType.secondary_storage) {`
	`585`	`+ if ((resourceType == ResourceType.primary_storage \|\| resourceType == ResourceType.secondary_storage) && max >= 0) {`
`586`	`586`	`max = max * ResourceType.bytesToGiB;`
`587`	`587`	`}`
`588`	`588`