CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set

anshulgangwar · devdeep · commit 66d1eb92f03c · 2014-06-13T13:26:02.000+05:30
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
@@ -773,7 +773,9 @@ public VolumeInfo createVolumeOnPrimaryStorage(VirtualMachine vm, VolumeInfo vol
             throw new CloudRuntimeException("Volume shouldn't be null " + volume.getId());
         }
         VolumeVO volVO = _volsDao.findById(vol.getId());
-        volVO.setFormat(getSupportedImageFormatForCluster(rootDiskHyperType));
+        if (volVO.getFormat() == null) {
+            volVO.setFormat(getSupportedImageFormatForCluster(rootDiskHyperType));
+        }
         _volsDao.update(volVO.getId(), volVO);
         return volFactory.getVolume(volVO.getId());
     }

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,9 @@ public VolumeInfo createVolumeOnPrimaryStorage(VirtualMachine vm, VolumeInfo vol`
`773`	`773`	`throw new CloudRuntimeException("Volume shouldn't be null " + volume.getId());`
`774`	`774`	`}`
`775`	`775`	`VolumeVO volVO = _volsDao.findById(vol.getId());`
`776`		`- volVO.setFormat(getSupportedImageFormatForCluster(rootDiskHyperType));`
	`776`	`+ if (volVO.getFormat() == null) {`
	`777`	`+ volVO.setFormat(getSupportedImageFormatForCluster(rootDiskHyperType));`
	`778`	`+ }`
`777`	`779`	`_volsDao.update(volVO.getId(), volVO);`
`778`	`780`	`return volFactory.getVolume(volVO.getId());`
`779`	`781`	`}`