Cleanup in UriUtils.getUpdateUri

K0zka · K0zka · commit 351ccf3755f0 · 2014-02-11T20:44:57.000+01:00
- String instantiation replaced with StringBuilder and empty string constant

Signed-off-by: Laszlo Hornyak &lt;laszlo.hornyak@gmail.com&gt;
diff --git a/utils/src/com/cloud/utils/UriUtils.java b/utils/src/com/cloud/utils/UriUtils.java
@@ -143,7 +143,7 @@ public static String getUpdateUri(String url, boolean encrypt) {
             URIBuilder builder = new URIBuilder(url);
             builder.removeQuery();
 
-            String updatedQuery = new String();
+            StringBuilder updatedQuery = new StringBuilder();
             List<NameValuePair> queryParams = getUserDetails(query);
             ListIterator<NameValuePair> iterator = queryParams.listIterator();
             while (iterator.hasNext()) {
@@ -156,14 +156,16 @@ public static String getUpdateUri(String url, boolean encrypt) {
                     value = param.getValue();
                 }
 
-                if (updatedQuery.isEmpty()) {
-                    updatedQuery += (param.getName() + "=" + value);
+                if (updatedQuery.length() == 0) {
+                    updatedQuery.append(param.getName()).append('=')
+                            .append(value);
                 } else {
-                    updatedQuery += ("&" + param.getName() + "=" + value);
+                    updatedQuery.append('&').append(param.getName())
+                            .append('=').append(value);
                 }
             }
 
-            String schemeAndHost = new String();
+            String schemeAndHost = "";
             URI newUri = builder.build();
             if (newUri.getScheme() != null) {
                 schemeAndHost = newUri.getScheme() + "://" + newUri.getHost();
diff --git a/utils/test/com/cloud/utils/UriUtilsTest.java b/utils/test/com/cloud/utils/UriUtilsTest.java
@@ -47,6 +47,10 @@ public void getUpdateUri() {
                 "http://localhost/foo/bar?password=1234", true).startsWith(
                 "http://localhost/foo/bar"));
 
+        //just to see if it is still ok with multiple parameters
+        Assert.assertEquals("http://localhost/foo/bar?param1=true&param2=12345", UriUtils
+                .getUpdateUri("http://localhost/foo/bar?param1=true&param2=12345", false));
+
         //XXX: Interesting cases not covered:
         // * port is ignored and left out from the return value
     }
