Skip to content

Commit 2adb9af

Browse files
kc284Alena Prokharchyk
authored andcommitted
Added version info to command and response parameters introduced in 4.4. Renamed newly introduced parameter StoragePoolReponse.overProvisionFactor to comply with coding conventions.
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
1 parent d65d9c8 commit 2adb9af

18 files changed

Lines changed: 46 additions & 32 deletions

api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,19 +118,20 @@ public class CreateServiceOfferingCmd extends BaseCmd {
118118
@Parameter(name = ApiConstants.IOPS_WRITE_RATE, type = CommandType.LONG, required = false, description = "io requests write rate of the disk offering")
119119
private Long iopsWriteRate;
120120

121-
@Parameter(name = ApiConstants.CUSTOMIZED_IOPS, type = CommandType.BOOLEAN, required = false, description = "whether compute offering iops is custom or not")
121+
@Parameter(name = ApiConstants.CUSTOMIZED_IOPS, type = CommandType.BOOLEAN, required = false, description = "whether compute offering iops is custom or not", since = "4.4")
122122
private Boolean customizedIops;
123123

124-
@Parameter(name = ApiConstants.MIN_IOPS, type = CommandType.LONG, required = false, description = "min iops of the compute offering")
124+
@Parameter(name = ApiConstants.MIN_IOPS, type = CommandType.LONG, required = false, description = "min iops of the compute offering", since = "4.4")
125125
private Long minIops;
126126

127-
@Parameter(name = ApiConstants.MAX_IOPS, type = CommandType.LONG, required = false, description = "max iops of the compute offering")
127+
@Parameter(name = ApiConstants.MAX_IOPS, type = CommandType.LONG, required = false, description = "max iops of the compute offering", since = "4.4")
128128
private Long maxIops;
129129

130130
@Parameter(name = ApiConstants.HYPERVISOR_SNAPSHOT_RESERVE,
131131
type = CommandType.INTEGER,
132132
required = false,
133-
description = "Hypervisor snapshot reserve space as a percent of a volume (for managed storage using Xen or VMware)")
133+
description = "Hypervisor snapshot reserve space as a percent of a volume (for managed storage using Xen or VMware)",
134+
since = "4.4")
134135
private Integer hypervisorSnapshotReserve;
135136

136137
/////////////////////////////////////////////////////

api/src/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd {
6666
+ "If not specified, the provider for the service will be mapped to the default provider on the physical network")
6767
private Map<String, String> serviceProviderList;
6868

69-
@Parameter(name = ApiConstants.SERVICE_CAPABILITY_LIST, type = CommandType.MAP, description = "desired service capabilities as part of vpc offering")
69+
@Parameter(name = ApiConstants.SERVICE_CAPABILITY_LIST, type = CommandType.MAP, description = "desired service capabilities as part of vpc offering", since = "4.4")
7070
private Map serviceCapabilitystList;
7171

7272
@Parameter(name = ApiConstants.SERVICE_OFFERING_ID,

api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class ListAutoScaleVmProfilesCmd extends BaseListProjectAndAccountResourc
5151
@Parameter(name = ApiConstants.TEMPLATE_ID, type = CommandType.UUID, entityType = TemplateResponse.class, description = "the templateid of the autoscale vm profile")
5252
private Long templateId;
5353

54-
@Parameter(name = ApiConstants.SERVICE_OFFERING_ID, type = CommandType.UUID, entityType = ServiceOfferingResponse.class, description = "list profiles by service offering id")
54+
@Parameter(name = ApiConstants.SERVICE_OFFERING_ID, type = CommandType.UUID, entityType = ServiceOfferingResponse.class, description = "list profiles by service offering id", since = "4.4")
5555
private Long serviceOffId;
5656

5757
@Parameter(name = ApiConstants.OTHER_DEPLOY_PARAMS, type = CommandType.STRING, description = "the otherdeployparameters of the autoscale vm profile")

api/src/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class UpdatePortForwardingRuleCmd extends BaseAsyncCustomIdCmd {
4646
/////////////////////////////////////////////////////
4747
//////////////// API parameters /////////////////////
4848
/////////////////////////////////////////////////////
49-
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = FirewallRuleResponse.class, required = true, description = "the ID of the port forwarding rule")
49+
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = FirewallRuleResponse.class, required = true, description = "the ID of the port forwarding rule", since = "4.4")
5050
private Long id;
5151

5252
@Parameter(name = ApiConstants.PRIVATE_IP, type = CommandType.STRING, description = "the private IP address of the port forwarding rule")

api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@ public class AssignToLoadBalancerRuleCmd extends BaseAsyncCmd {
7070
description = "the list of IDs of the virtual machine that are being assigned to the load balancer rule(i.e. virtualMachineIds=1,2,3)")
7171
private List<Long> virtualMachineIds;
7272

73-
@Parameter(name = ApiConstants.VIRTUAL_MACHINE_ID_IP, type = CommandType.MAP, description = "VM ID and IP map, vmidipmap[0].vmid=1 vmidipmap[0].ip=10.1.1.75")
73+
@Parameter(name = ApiConstants.VIRTUAL_MACHINE_ID_IP,
74+
type = CommandType.MAP,
75+
description = "VM ID and IP map, vmidipmap[0].vmid=1 vmidipmap[0].ip=10.1.1.75",
76+
since = "4.4")
7477
private Map vmIdIpMap;
7578

7679
/////////////////////////////////////////////////////

api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,10 @@ public class DeployVMCmd extends BaseAsyncCreateCustomIdCmd {
121121
@Parameter(name = ApiConstants.SIZE, type = CommandType.LONG, description = "the arbitrary size for the DATADISK volume. Mutually exclusive with diskOfferingId")
122122
private Long size;
123123

124-
@Parameter(name = ApiConstants.ROOT_DISK_SIZE, type = CommandType.LONG, description = "Optional field to resize root disk on deploy. Only applies to template-based deployments. Analogous to details[0].rootdisksize, which takes precedence over this parameter if both are provided")
124+
@Parameter(name = ApiConstants.ROOT_DISK_SIZE,
125+
type = CommandType.LONG,
126+
description = "Optional field to resize root disk on deploy. Only applies to template-based deployments. Analogous to details[0].rootdisksize, which takes precedence over this parameter if both are provided",
127+
since = "4.4")
125128
private Long rootdisksize;
126129

127130
@Parameter(name = ApiConstants.GROUP, type = CommandType.STRING, description = "an optional group for the virtual machine")

api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,11 @@ public class ListVolumesCmd extends BaseListTaggedResourcesCmd {
7676
authorized = {RoleType.Admin})
7777
private Long storageId;
7878

79-
@Parameter(name = ApiConstants.DISK_OFFERING_ID, type = CommandType.UUID, entityType = DiskOfferingResponse.class, description = "list volumes by disk offering")
79+
@Parameter(name = ApiConstants.DISK_OFFERING_ID,
80+
type = CommandType.UUID,
81+
entityType = DiskOfferingResponse.class,
82+
description = "list volumes by disk offering",
83+
since = "4.4")
8084
private Long diskOfferingId;
8185

8286
@Parameter(name = ApiConstants.DISPLAY_VOLUME, type = CommandType.BOOLEAN, description = "list resources by display flag; only ROOT admin is eligible to pass this parameter", since = "4.4", authorized = {RoleType.Admin})

api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,10 @@ public class UpdateVolumeCmd extends BaseAsyncCustomIdCmd {
5454
@Parameter(name = ApiConstants.PATH, type = CommandType.STRING, description = "The path of the volume")
5555
private String path;
5656

57-
@Parameter(name = ApiConstants.CHAIN_INFO, type = CommandType.STRING, description = "The chain info of the volume")
57+
@Parameter(name = ApiConstants.CHAIN_INFO,
58+
type = CommandType.STRING,
59+
description = "The chain info of the volume",
60+
since = "4.4")
5861
private String chainInfo;
5962

6063
@Parameter(name = ApiConstants.STORAGE_ID,

api/src/org/apache/cloudstack/api/response/AccountResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ public class AccountResponse extends BaseResponse implements ResourceLimitAndCou
240240
private Boolean isDefault;
241241

242242
@SerializedName(ApiConstants.IAM_GROUPS)
243-
@Param(description = "the list of acl groups that account belongs to")
243+
@Param(description = "the list of acl groups that account belongs to", since = "4.4")
244244
private List<String> groups;
245245

246246
@Override

api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public class DiskOfferingResponse extends BaseResponse {
7474
private Long maxIops;
7575

7676
@SerializedName(ApiConstants.HYPERVISOR_SNAPSHOT_RESERVE)
77-
@Param(description = "Hypervisor snapshot reserve space as a percent of a volume (for managed storage using Xen or VMware)")
77+
@Param(description = "Hypervisor snapshot reserve space as a percent of a volume (for managed storage using Xen or VMware)", since = "4.4")
7878
private Integer hypervisorSnapshotReserve;
7979

8080
@SerializedName(ApiConstants.TAGS)
@@ -102,7 +102,7 @@ public class DiskOfferingResponse extends BaseResponse {
102102
private Long iopsWriteRate;
103103

104104
@SerializedName("cacheMode")
105-
@Param(description = "the cache mode to use for this disk offering. none, writeback or writethrough")
105+
@Param(description = "the cache mode to use for this disk offering. none, writeback or writethrough", since = "4.4")
106106
private String cacheMode;
107107

108108
@SerializedName("displayoffering")

0 commit comments

Comments
 (0)