CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection.

Santhosh Edukulla · Prasanna Santhanam · commit 175ead4ea96b · 2013-11-11T10:26:32.000+05:30
The bug mentioned is causing test cases to fail.

Signed-off-by: Santhosh Edukulla &lt;Santhosh.Edukulla@citrix.com&gt;
diff --git a/tools/marvin/marvin/cloudstackConnection.py b/tools/marvin/marvin/cloudstackConnection.py
@@ -36,7 +36,7 @@ class cloudConnection(object):
     """ Connections to make API calls to the cloudstack management server
     """
     def __init__(self, mgmtDet, asyncTimeout=3600, logging=None,
-                 scheme='http', path='client/api'):
+                 path='client/api'):
         self.loglevel()  # Turn off requests logs
         self.apiKey = mgmtDet.apiKey
         self.securityKey = mgmtDet.securityKey
@@ -49,7 +49,8 @@ def __init__(self, mgmtDet, asyncTimeout=3600, logging=None,
         self.logging = logging
         self.path = path
         self.retries = 5
-        self.protocol = scheme
+        self.mgtDetails = mgmtDet
+        self.protocol = "http"
         self.asyncTimeout = asyncTimeout
         self.auth = True
         if self.port == 8096 or \
@@ -61,11 +62,9 @@ def __init__(self, mgmtDet, asyncTimeout=3600, logging=None,
                        % (self.protocol, self.mgtSvr, self.port, self.path)
 
     def __copy__(self):
-        return cloudConnection(self.mgtSvr, self.port, self.user,
-                               self.passwd, self.apiKey,
-                               self.securityKey,
-                               self.asyncTimeout, self.logging,
-                               self.protocol,
+        return cloudConnection(self.mgtDetails,
+                               self.asyncTimeout,
+                               self.logging,
                                self.path)
 
     def loglevel(self, lvl=logging.WARNING):
diff --git a/tools/marvin/marvin/cloudstackTestClient.py b/tools/marvin/marvin/cloudstackTestClient.py
@@ -41,8 +41,9 @@ def __init__(self, mgmtDetails,
                  dbSvrDetails, asyncTimeout=3600,
                  defaultWorkerThreads=10,
                  logging=None):
+        self.mgmtDetails = mgmtDetails
         self.connection = \
-            cloudstackConnection.cloudConnection(mgmtDetails,
+            cloudstackConnection.cloudConnection(self.mgmtDetails,
                                                  asyncTimeout,
                                                  logging)
         self.apiClient =\
@@ -148,12 +149,12 @@ def createUserApiClient(self, UserName, DomainName, acctType=0):
             apiKey = registerUserRes.apikey
             securityKey = registerUserRes.secretkey
 
+        mgtDetails = self.mgmtDetails
+        mgtDetails.apiKey = apiKey
+        mgtDetails.securityKey = securityKey
+
         newUserConnection =\
-            cloudstackConnection.cloudConnection(self.connection.mgtSvr,
-                                                 self.connection.port,
-                                                 self.connection.user,
-                                                 self.connection.passwd,
-                                                 apiKey, securityKey,
+            cloudstackConnection.cloudConnection(mgtDetails,
                                                  self.connection.asyncTimeout,
                                                  self.connection.logging)
         self.userApiClient =\
diff --git a/tools/marvin/marvin/integration/lib/utils.py b/tools/marvin/marvin/integration/lib/utils.py
@@ -157,10 +157,7 @@ def fetch_api_client(config_file='datacenterCfg'):
     asyncTimeout = 3600
     return cloudstackAPIClient.CloudStackAPIClient(
         marvin.cloudstackConnection.cloudConnection(
-            mgt.mgtSvrIp,
-            mgt.port,
-            mgt.apiKey,
-            mgt.securityKey,
+            mgt,
             asyncTimeout,
             testClientLogger
         )
diff --git a/tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py b/tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py
@@ -76,10 +76,7 @@ def fetch_api_client(config_file='datacenterCfg'):
     asyncTimeout = 3600
     return cloudstackAPIClient.CloudStackAPIClient(
             cloudstackConnection.cloudConnection(
-                                                mgt.mgtSvrIp,
-                                                mgt.port,
-                                                mgt.apiKey,
-                                                mgt.securityKey,
+                                                mgt,
                                                 asyncTimeout,
                                                 testClientLogger
                                                 )
