findbugs: check for system template id == -> equals()

DaanHoogland · spark404 · commit 15fa2ef8df10 · 2014-02-14T18:37:47.000+01:00
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -1753,12 +1753,7 @@ private VMTemplateVO updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
             throw ex;
         }
 
-        // Don't allow to modify system template
-        if (id == Long.valueOf(1)) {
-            InvalidParameterValueException ex = new InvalidParameterValueException("Unable to update template/iso of specified id");
-            ex.addProxyObject(String.valueOf(id), "templateId");
-            throw ex;
-        }
+        verifyTemplateId(id);
 
         // do a permission check
         _accountMgr.checkAccess(account, AccessType.ModifyEntry, true, template);
@@ -1835,6 +1830,15 @@ private VMTemplateVO updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
         return _tmpltDao.findById(id);
     }
 
+    void verifyTemplateId(Long id) {
+        // Don't allow to modify system template
+        if (id.equals(Long.valueOf(1))) {
+            InvalidParameterValueException ex = new InvalidParameterValueException("Unable to update template/iso of specified id");
+            ex.addProxyObject(String.valueOf(id), "templateId");
+            throw ex;
+        }
+    }
+
     @Override
     public String getConfigComponentName() {
         return TemplateManager.class.getSimpleName();
diff --git a/server/test/com/cloud/template/TemplateManagerImplTest.java b/server/test/com/cloud/template/TemplateManagerImplTest.java
@@ -0,0 +1,19 @@
+package com.cloud.template;
+
+import org.junit.Test;
+
+import com.cloud.exception.InvalidParameterValueException;
+
+public class TemplateManagerImplTest {
+
+    TemplateManagerImpl tmgr = new TemplateManagerImpl();
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void testVerifyTemplateIdOfSystemTemplate() {
+        tmgr.verifyTemplateId(1L);
+    }
+
+    public void testVerifyTemplateIdOfNonSystemTemplate() {
+        tmgr.verifyTemplateId(1L);
+    }
+}
