removed Integer and Long instantiations

K0zka · K0zka · commit 05c9d54c4fdf · 2014-03-28T18:40:25.000+01:00
Signed-off-by: Laszlo Hornyak &lt;laszlo.hornyak@gmail.com&gt;
diff --git a/server/src/com/cloud/network/security/SecurityGroupWorkTracker.java b/server/src/com/cloud/network/security/SecurityGroupWorkTracker.java
@@ -48,8 +48,8 @@ public boolean canSend(long agentId) {
         synchronized (this) {
             Integer outstanding = _unackedMessages.get(agentId);
             if (outstanding == null) {
-                outstanding = new Integer(0);
-                _unackedMessages.put(new Long(agentId), outstanding);
+                outstanding = 0;
+                _unackedMessages.put(agentId, outstanding);
             }
             currLength = outstanding.intValue();
             if (currLength + 1 > _bufferLength) {
@@ -58,7 +58,7 @@ public boolean canSend(long agentId) {
                 s_logger.debug("SecurityGroupManager: dropping a message because there are more than " + currLength + " outstanding messages, total dropped=" + discarded);
                 return false;
             }
-            _unackedMessages.put(new Long(agentId), ++currLength);
+            _unackedMessages.put(agentId, ++currLength);
         }
         return true;
     }

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ public boolean canSend(long agentId) {`
`48`	`48`	`synchronized (this) {`
`49`	`49`	`Integer outstanding = _unackedMessages.get(agentId);`
`50`	`50`	`if (outstanding == null) {`
`51`		`- outstanding = new Integer(0);`
`52`		`- _unackedMessages.put(new Long(agentId), outstanding);`
	`51`	`+ outstanding = 0;`
	`52`	`+ _unackedMessages.put(agentId, outstanding);`
`53`	`53`	`}`
`54`	`54`	`currLength = outstanding.intValue();`
`55`	`55`	`if (currLength + 1 > _bufferLength) {`
`@@ -58,7 +58,7 @@ public boolean canSend(long agentId) {`
`58`	`58`	`s_logger.debug("SecurityGroupManager: dropping a message because there are more than " + currLength + " outstanding messages, total dropped=" + discarded);`
`59`	`59`	`return false;`
`60`	`60`	`}`
`61`		`- _unackedMessages.put(new Long(agentId), ++currLength);`
	`61`	`+ _unackedMessages.put(agentId, ++currLength);`
`62`	`62`	`}`
`63`	`63`	`return true;`
`64`	`64`	`}`