Cut xtrace noise from POSIX-ownership diagnostic steps

EliahKagan · claude · EliahKagan · commit e3a75d0bf386 · 2026-05-23T17:42:32.000-04:00
The "Show POSIX file ownership" step in each test workflow looped over a hard-coded path list with one `ls -ld` per iteration. Bash's xtrace -- active throughout (from `~/.bash_profile` on Cygwin and from the `-x` flag in GHA's default shell line on Ubuntu / macOS / Alpine) -- reprints the entire `for` expression's expanded word list at the start of every iteration. For nine paths that's nine long traces of the same word list, drowning out the `ls -ld` output we want to read. Collapse the loop into a single multi-arg `ls -ld --`: xtrace prints the expanded command line once, `ls` produces one line per existing path and a `ls: cannot access '<path>': No such file or directory` line per missing path. `2>&1` merges those missing-path messages into the log stream alongside the existing-path output; `|| true` keeps the step from failing under `set -e` when any path is missing. The format of missing-path reporting changes from `(missing: <path>)` to `ls: cannot access '<path>': No such file or directory`. Both convey the same information; the new form is slightly more verbose per missing path but eliminates the per-iteration trace reprint that dominated the original output. Cosmetic-only; no change to the diagnostic information surfaced. Flagged on PR #2154 as a follow-up: #2154 (review) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
diff --git a/.github/workflows/alpine-test.yml b/.github/workflows/alpine-test.yml
@@ -63,17 +63,15 @@ jobs:
 
     - name: Show POSIX file ownership
       run: |
-        for p in \
+        ls -ld -- \
           "$(pwd)" \
           "$(pwd)/.git" \
           "$(pwd)/git/ext/gitdb" \
           "$(pwd)/git/ext/gitdb/.git" \
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap" \
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap/.git" \
-          "${HOME:?HOME is not set}/.gitconfig"
-        do
-          ls -ld -- "$p" 2>/dev/null || echo "(missing: $p)"
-        done
+          "${HOME:?HOME is not set}/.gitconfig" \
+          2>&1 || true
 
     - name: Show safe.directory entries
       # `actions/checkout`'s safe.directory add is only durable for the
diff --git a/.github/workflows/cygwin-test.yml b/.github/workflows/cygwin-test.yml
@@ -89,7 +89,7 @@ jobs:
       # `is_path_owned_by_current_user` reduces to, so this is the view that
       # determines whether `safe.directory` is consulted.
       run: |
-        for p in \
+        ls -ld -- \
           "$(pwd)" \
           "$(pwd)/.git" \
           "$(pwd)/git/ext/gitdb" \
@@ -98,10 +98,8 @@ jobs:
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap" \
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap/.git" \
           "$(pwd)/.git/modules/gitdb/modules/smmap" \
-          "${HOME:?HOME is not set}/.gitconfig"
-        do
-          ls -ld -- "$p" 2>/dev/null || echo "(missing: $p)"
-        done
+          "${HOME:?HOME is not set}/.gitconfig" \
+          2>&1 || true
 
     - name: Show NTFS file ownership
       # Authoritative NTFS Owner via Get-Acl, with no Cygwin SID-to-uid layer
diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
@@ -94,17 +94,15 @@ jobs:
       # not be informative here. The NTFS Owner check below covers Windows.
       if: matrix.os-type != 'windows'
       run: |
-        for p in \
+        ls -ld -- \
           "$(pwd)" \
           "$(pwd)/.git" \
           "$(pwd)/git/ext/gitdb" \
           "$(pwd)/git/ext/gitdb/.git" \
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap" \
           "$(pwd)/git/ext/gitdb/gitdb/ext/smmap/.git" \
-          "${HOME:?HOME is not set}/.gitconfig"
-        do
-          ls -ld -- "$p" 2>/dev/null || echo "(missing: $p)"
-        done
+          "${HOME:?HOME is not set}/.gitconfig" \
+          2>&1 || true
 
     - name: Show NTFS file ownership
       # Windows only. Reads NTFS Owner directly via Get-Acl, which is the
