Address review comment about unterminated subsection quotes

codex · Byron · commit 9bee00338d8c · 2026-07-20T13:34:37.000+02:00
Review feedback: Section-name validation treated closing brackets as quoted data even when the opening quote was never closed or ended with a trailing escape. The tests also lacked those malformed quoted-subsection cases.

Reject section names whose quote state remains open after scanning the complete name. Extend the existing writer-entry-point regression matrix with both an unterminated quoted subsection and one ending in a trailing escape, while retaining the valid quoted-bracket case.
diff --git a/git/config.py b/git/config.py
@@ -909,6 +909,8 @@ def _assure_config_name_safe(self, name: "cp._SectionName", label: str) -> None:
                     in_quotes = not in_quotes
                 elif char == "]" and not in_quotes:
                     raise ValueError("Git config section names must not contain an unquoted closing bracket")
+            if in_quotes:
+                raise ValueError("Git config section names must not contain an unterminated quote")
 
     @needs_values
     @set_dirty_and_flush_changes
diff --git a/test/test_config.py b/test/test_config.py
@@ -197,21 +197,26 @@ def test_set_value_rejects_unsafe_section_and_option_names(self, rw_dir):
     @with_rw_directory
     def test_writer_rejects_unquoted_section_terminators(self, rw_dir):
         config_path = osp.join(rw_dir, "config")
-        bad_sections = ("user] [other", 'submodule "docs"] [other')
+        bad_sections = (
+            "user] [other",
+            'submodule "docs"] [other',
+            'submodule "docs] [other',
+            'submodule "docs] [other\\',
+        )
         safe_section = 'submodule "docs]archive"'
 
         with GitConfigParser(config_path, read_only=False) as git_config:
             git_config.add_section("user")
             for bad_section in bad_sections:
-                with pytest.raises(ValueError, match="closing bracket"):
+                with pytest.raises(ValueError, match="section name"):
                     git_config.add_section(bad_section)
-                with pytest.raises(ValueError, match="closing bracket"):
+                with pytest.raises(ValueError, match="section name"):
                     git_config.set(bad_section, "name", "value")
-                with pytest.raises(ValueError, match="closing bracket"):
+                with pytest.raises(ValueError, match="section name"):
                     git_config.set_value(bad_section, "name", "value")
-                with pytest.raises(ValueError, match="closing bracket"):
+                with pytest.raises(ValueError, match="section name"):
                     git_config.add_value(bad_section, "name", "value")
-                with pytest.raises(ValueError, match="closing bracket"):
+                with pytest.raises(ValueError, match="section name"):
                     git_config.rename_section("user", bad_section)
 
             git_config.set_value("user", "name", "safe")
