Only create watchdog and event if timeout is specified in execute command

OswinNathanial · dpursehouse · commit 7cc0e6caa311 · 2015-10-09T15:25:30.000+09:00
If the timeout is not specified, we don't need the overhead of
creating a watchdog and event.

Change-Id: I53ff891af24d4c27fb16bf4bb35910dd1d19d238
diff --git a/git/cmd.py b/git/cmd.py
@@ -602,8 +602,6 @@ def execute(self, command,
         if as_process:
             return self.AutoInterrupt(proc, command)
 
-        kill_check = threading.Event()
-
         def _kill_process(pid):
             """ Callback method to kill a process. """
             p = Popen(['ps', '--ppid', str(pid)], stdout=PIPE)
@@ -625,20 +623,24 @@ def _kill_process(pid):
             return
         # end
 
-        watchdog = threading.Timer(timeout, _kill_process, args=(proc.pid, ))
+        if timeout:
+            kill_check = threading.Event()
+            watchdog = threading.Timer(timeout, _kill_process, args=(proc.pid, ))
 
         # Wait for the process to return
         status = 0
         stdout_value = b''
         stderr_value = b''
         try:
             if output_stream is None:
-                watchdog.start()
+                if timeout:
+                    watchdog.start()
                 stdout_value, stderr_value = proc.communicate()
-                watchdog.cancel()
-                if kill_check.isSet():
-                    stderr_value = 'Timeout: the command "%s" did not complete in %d ' \
-                                   'secs.' % (" ".join(command), timeout)
+                if timeout:
+                    watchdog.cancel()
+                    if kill_check.isSet():
+                        stderr_value = 'Timeout: the command "%s" did not complete in %d ' \
+                                       'secs.' % (" ".join(command), timeout)
                 # strip trailing "\n"
                 if stdout_value.endswith(b"\n"):
                     stdout_value = stdout_value[:-1]
