Remove function

Sam McHardy · Sam McHardy · commit 455f48ae6bdb · 2018-01-09T19:17:33.000+11:00
diff --git a/binance/helpers.py b/binance/helpers.py
@@ -1,4 +1,3 @@
-import time
 import dateparser
 import pytz
 
@@ -53,83 +52,3 @@ def interval_to_milliseconds(interval):
         except ValueError:
             pass
     return ms
-
-
-def get_historical_klines(symbol, interval, start_str, end_str=None):
-    """Get Historical Klines from Binance
-
-    See dateparse docs for valid start and end string formats http://dateparser.readthedocs.io/en/latest/
-
-    If using offset strings for dates add "UTC" to date string e.g. "now UTC", "11 hours ago UTC"
-
-    :param symbol: Name of symbol pair e.g BNBBTC
-    :type symbol: str
-    :param interval: Biannce Kline interval
-    :type interval: str
-    :param start_str: Start date string in UTC format
-    :type start_str: str
-    :param end_str: optional - end date string in UTC format
-    :type end_str: str
-
-    :return: list of OHLCV values
-
-    """
-    # create the Binance client, no need for api key
-    client = Client("", "")
-
-    # init our list
-    output_data = []
-
-    # setup the max limit
-    limit = 500
-
-    # convert interval to useful value in seconds
-    timeframe = interval_to_milliseconds(interval)
-
-    # convert our date strings to milliseconds
-    start_ts = date_to_milliseconds(start_str)
-
-    # if an end time was passed convert it
-    end_ts = None
-    if end_str:
-        end_ts = date_to_milliseconds(end_str)
-
-    idx = 0
-    # it can be difficult to know when a symbol was listed on Binance so allow start time to be before list date
-    symbol_existed = False
-    while True:
-        # fetch the klines from start_ts up to max 500 entries or the end_ts if set
-        temp_data = client.get_klines(
-            symbol=symbol,
-            interval=interval,
-            limit=limit,
-            startTime=start_ts,
-            endTime=end_ts
-        )
-
-        # handle the case where our start date is before the symbol pair listed on Binance
-        if not symbol_existed and len(temp_data):
-            symbol_existed = True
-
-        if symbol_existed:
-            # append this loops data to our output data
-            output_data += temp_data
-
-            # update our start timestamp using the last value in the array and add the interval timeframe
-            start_ts = temp_data[len(temp_data) - 1][0] + timeframe
-        else:
-            print("doesn't exist yet")
-            # it wasn't listed yet, increment our start date
-            start_ts += timeframe
-
-        idx += 1
-        # check if we received less than the required limit and exit the loop
-        if len(temp_data) < limit:
-            # exit the while loop
-            break
-
-        # sleep after every 3rd call to be kind to the API
-        if idx % 3 == 0:
-            time.sleep(1)
-
-    return output_data
