Eliminate warnings about #warning (MeVisLab#122)

jbowler · mrbean-bremen · commit b4546690da22 · 2023-11-02T20:39:00.000+01:00
The warnings are already only emitted with GCC so changing them to the
GCC diagnostic pragma is safe.
diff --git a/generator/parser/declarator_compiler.cpp b/generator/parser/declarator_compiler.cpp
@@ -135,7 +135,7 @@ void DeclaratorCompiler::visitPtrOperator(PtrOperatorAST *node)
   if (node->mem_ptr)
     {
 #if defined(__GNUC__)
-#warning "ptr to mem -- not implemented"
+#pragma GCC warning "ptr to mem -- not implemented"
 #endif
     }
 }
diff --git a/generator/parser/name_compiler.cpp b/generator/parser/name_compiler.cpp
@@ -80,7 +80,7 @@ void NameCompiler::visitUnqualifiedName(UnqualifiedNameAST *node)
   if (OperatorFunctionIdAST *op_id = node->operator_id)
     {
 #if defined(__GNUC__)
-#warning "NameCompiler::visitUnqualifiedName() -- implement me"
+#pragma GCC warning "NameCompiler::visitUnqualifiedName() -- implement me"
 #endif
 
       if (op_id->op && op_id->op->op)
@@ -93,7 +93,7 @@ void NameCompiler::visitUnqualifiedName(UnqualifiedNameAST *node)
       else if (op_id->type_specifier)
         {
 #if defined(__GNUC__)
-#warning "don't use an hardcoded string as cast' name"
+#pragma GCC warning "don't use an hardcoded string as cast' name"
 #endif
           Token const &tk = _M_token_stream->token ((int) op_id->start_token);
           Token const &end_tk = _M_token_stream->token ((int) op_id->end_token);
diff --git a/generator/parser/parser.cpp b/generator/parser/parser.cpp
@@ -840,7 +840,7 @@ bool Parser::parseAsmDefinition(DeclarationAST *&node)
   parseCvQualify(cv);
 
 #if defined(__GNUC__)
-#warning "implement me"
+#pragma GCC warning "implement me"
 #endif
   skip('(', ')');
   token_stream.nextToken();
@@ -2427,7 +2427,7 @@ bool Parser::parseInitializerClause(InitializerClauseAST *&node)
   if (token_stream.lookAhead() == '{')
     {
 #if defined(__GNUC__)
-#warning "implement me"
+#pragma GCC warning "implement me"
 #endif
       if (skip('{','}'))
         token_stream.nextToken();
@@ -2451,7 +2451,7 @@ bool Parser::parseInitializerClause(InitializerClauseAST *&node)
 bool Parser::parsePtrToMember(PtrToMemberAST *&node)
 {
 #if defined(__GNUC__)
-#warning "implemente me (AST)"
+#pragma GCC warning "implemente me (AST)"
 #endif
 
   std::size_t start = token_stream.cursor();
@@ -2625,15 +2625,15 @@ bool Parser::parseStatement(StatementAST *&node)
     case Token_break:
     case Token_continue:
 #if defined(__GNUC__)
-#warning "implement me"
+#pragma GCC warning "implement me"
 #endif
       token_stream.nextToken();
       ADVANCE(';', ";");
       return true;
 
     case Token_goto:
 #if defined(__GNUC__)
-#warning "implement me"
+#pragma GCC warning "implement me"
 #endif
       token_stream.nextToken();
       ADVANCE(Token_identifier, "identifier");
@@ -3279,7 +3279,7 @@ bool Parser::parseDeclarationInternal(DeclarationAST *&node)
       ADVANCE(';', ";");
 
 #if defined(__GNUC__)
-#warning "mark the ast as constant"
+#pragma GCC warning "mark the ast as constant"
 #endif
       SimpleDeclarationAST *ast = CreateNode<SimpleDeclarationAST>(_M_pool);
       ast->init_declarators = declarators;
@@ -3380,7 +3380,7 @@ bool Parser::parseDeclarationInternal(DeclarationAST *&node)
 bool Parser::skipFunctionBody(StatementAST *&)
 {
 #if defined(__GNUC__)
-#warning "Parser::skipFunctionBody() -- implement me"
+#pragma GCC warning "Parser::skipFunctionBody() -- implement me"
 #endif
   Q_ASSERT(0); // ### not implemented
   return 0;
@@ -3409,7 +3409,7 @@ bool Parser::parseTypeSpecifierOrClassSpec(TypeSpecifierAST *&node)
 bool Parser::parseTryBlockStatement(StatementAST *&node)
 {
 #if defined(__GNUC__)
-#warning "implement me"
+#pragma GCC warning "implement me"
 #endif
   CHECK(Token_try);
 

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ void DeclaratorCompiler::visitPtrOperator(PtrOperatorAST *node)`
`135`	`135`	`if (node->mem_ptr)`
`136`	`136`	`{`
`137`	`137`	`#if defined(__GNUC__)`
`138`		`-#warning "ptr to mem -- not implemented"`
	`138`	`+#pragma GCC warning "ptr to mem -- not implemented"`
`139`	`139`	`#endif`
`140`	`140`	`}`
`141`	`141`	`}`