Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Node upgrade / deprecation warnings #76

Open

Description

@alecglen

Getting these in the action summary:

image

Activity

  1. akosiaris commented on Dec 16, 2022

    @akosiaris

    I am meeting this too. I see that the last commit in this repo is in Aug 2021. Is this action still maintained?

  2. aslak01 commented on Jan 20, 2023

    @aslak01

    I'm also seeing these warnings. Hope it'll be resolve. Node LTS is already on v18 👀

  3. skhalaf21 commented on Feb 8, 2023

    @skhalaf21

    Any word on this? are there any plans to patch this action so it does not throw this Node 12 warning and eventually stop working?

  4. alecglen commented on Feb 12, 2023

    @alecglen
    Author
  5. NargiT commented on Mar 19, 2023

    @NargiT

    any news ?

  6. aslak01 commented on May 23, 2023

    @aslak01

    My project no longer runs as of today due to node 12 depreciation. Anyone know of an alternative to this or willing to make a fork?

    Edit on closer inspection it appears to be a problem with the deno package repo, but summer of depreciation is coming quite fast.

  7. alecglen commented on May 23, 2023

    @alecglen
    Author

    Very frustrating abandonment and lack of communication here; it really makes me distrustful of other Github Next initiatives...

    @aslak01 Personally I switched to using an Azure data factory a while ago. I'm not a Node guy, but it might not be much work to roll my Python into an action with similar functionality. I can take a swing at it sometime in the next month if there's interest?

  8. mattrothenberg commented on May 24, 2023

    @mattrothenberg
    Contributor

    @alecglen @aslak01 I totally hear your frustration. Sincere apologies for the delay on this front.

    I have a PR open that should hopefully fix this issue: #86.

    I'm by no means an actions expert, so can you try giving this PR a test by pinning the version of the action in your repo to githubocto/flat@mr/node16 and letting me know if it works?

  9. added a commit that references this issue on Jun 6, 2023
  10. akosiaris commented on Jun 6, 2023

    @akosiaris

    @mattrothenberg

    Hi, thanks for your work on this. I have switched to using the action you suggested today. It fixes the issue reported here and also works fine for my use case. I 'll let it run (it runs on a schedule) for a couple of weeks and report back here.

  11. mattrothenberg commented on Jun 7, 2023

    @mattrothenberg
    Contributor

    This should hopefully be fixed in https://github.com/githubocto/flat/releases/tag/3.4.0 🤞

  12. alecglen commented on Jun 21, 2023

    @alecglen
    Author

    Much appreciated, @mattrothenberg!

    I think this is working for me too, but there's something I'm missing. Hopefully the gang assembled here can help make it make sense?

    I haven't updated my my flat.yaml since the release, but I checked just now and the deprecation warnings are indeed gone as of a couple weeks ago. I'm confused because from what I can tell in the action logs, it's still running with an older version (3.3.1 based on the SHA).

    ...
    Download action repository 'githubocto/flat@v3' (SHA:fc34373cc20b987e89d75d96435a9fecd8fb0807)
    ...
    

    However, the warnings are definitely gone, so I'm not sure what to believe 🤷 . Is there anything I need to do explicitly in the yaml to make sure I'm on the new release?

  13. mattrothenberg commented on Jun 21, 2023

    @mattrothenberg
    Contributor

    @alecglen That sounds weird! Are you able to link to the particular action run where you're seeing that?

  14. alecglen commented on Jun 21, 2023

    @alecglen
    Author

    Yeah I can ...it's just in a private repo that isn't actually top-secret haha. Just sent you a collaborator invite so you can view it.

  15. mattrothenberg commented on Jun 21, 2023

    @mattrothenberg
    Contributor

    Great, will take a look tomorrow!

  16. akosiaris commented on Jun 21, 2023

    @akosiaris

    @mattrothenberg

    Hi, thanks for your work on this. I have switched to using the action you suggested today. It fixes the issue reported here and also works fine for my use case. I 'll let it run (it runs on a schedule) for a couple of weeks and report back here.

    Couple of weeks passed, not a single error for me. Many thanks again!

  17. dalanmiller commented on Jul 19, 2023

    @dalanmiller

    Still getting this on flat@v3 unfortunately? Not sure why.

  18. skhalaf21 commented on Jul 19, 2023

    @skhalaf21

    @dalanmiller have you tried with githubocto/flat@v3.4.0 ?

  19. dalanmiller commented on Jul 19, 2023

    @dalanmiller

    Ahhhh wonderful that was it.

    I assumed incorrectly that using @v3 would grab the latest minor point release.

  20. skhalaf21 commented on Jul 20, 2023

    @skhalaf21

    @dalanmiller no problem. Actually, that's what I also though, but apparently it was not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions