chore: adjust way skill dirs are whitelisted (anomalyco#12026)

rekram1-node · web-flow · commit a68fedd4a6bc · 2026-02-03T16:33:36.000-06:00
diff --git a/packages/opencode/src/skill/skill.ts b/packages/opencode/src/skill/skill.ts
@@ -50,6 +50,7 @@ export namespace Skill {
 
   export const state = Instance.state(async () => {
     const skills: Record<string, Info> = {}
+    const dirs = new Set<string>()
 
     const addSkill = async (match: string) => {
       const md = await ConfigMarkdown.parse(match).catch((err) => {
@@ -75,6 +76,8 @@ export namespace Skill {
         })
       }
 
+      dirs.add(path.dirname(match))
+
       skills[parsed.data.name] = {
         name: parsed.data.name,
         description: parsed.data.description,
@@ -148,11 +151,9 @@ export namespace Skill {
       }
     }
 
-    const dirs = Array.from(new Set(Object.values(skills).map((item) => path.dirname(item.location))))
-
     return {
       skills,
-      dirs,
+      dirs: Array.from(dirs),
     }
   })
 
diff --git a/packages/opencode/test/skill/skill.test.ts b/packages/opencode/test/skill/skill.test.ts
@@ -326,3 +326,63 @@ description: A skill in the .agents/skills directory.
     },
   })
 })
+
+test("properly resolves directories that skills live in", async () => {
+  await using tmp = await tmpdir({
+    git: true,
+    init: async (dir) => {
+      const opencodeSkillDir = path.join(dir, ".opencode", "skill", "agent-skill")
+      const opencodeSkillsDir = path.join(dir, ".opencode", "skills", "agent-skill")
+      const claudeDir = path.join(dir, ".claude", "skills", "claude-skill")
+      const agentDir = path.join(dir, ".agents", "skills", "agent-skill")
+      await Bun.write(
+        path.join(claudeDir, "SKILL.md"),
+        `---
+name: claude-skill
+description: A skill in the .claude/skills directory.
+---
+
+# Claude Skill
+`,
+      )
+      await Bun.write(
+        path.join(agentDir, "SKILL.md"),
+        `---
+name: agent-skill
+description: A skill in the .agents/skills directory.
+---
+
+# Agent Skill
+`,
+      )
+      await Bun.write(
+        path.join(opencodeSkillDir, "SKILL.md"),
+        `---
+name: opencode-skill
+description: A skill in the .opencode/skill directory.
+---
+
+# OpenCode Skill
+`,
+      )
+      await Bun.write(
+        path.join(opencodeSkillsDir, "SKILL.md"),
+        `---
+name: opencode-skill
+description: A skill in the .opencode/skills directory.
+---
+
+# OpenCode Skill
+`,
+      )
+    },
+  })
+
+  await Instance.provide({
+    directory: tmp.path,
+    fn: async () => {
+      const dirs = await Skill.dirs()
+      expect(dirs.length).toBe(4)
+    },
+  })
+})

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ export namespace Skill {`
`50`	`50`
`51`	`51`	`export const state = Instance.state(async () => {`
`52`	`52`	`const skills: Record<string, Info> = {}`
	`53`	`+ const dirs = new Set<string>()`
`53`	`54`
`54`	`55`	`const addSkill = async (match: string) => {`
`55`	`56`	`const md = await ConfigMarkdown.parse(match).catch((err) => {`
`@@ -75,6 +76,8 @@ export namespace Skill {`
`75`	`76`	`})`
`76`	`77`	`}`
`77`	`78`
	`79`	`+ dirs.add(path.dirname(match))`
	`80`	`+`
`78`	`81`	`skills[parsed.data.name] = {`
`79`	`82`	`name: parsed.data.name,`
`80`	`83`	`description: parsed.data.description,`
`@@ -148,11 +151,9 @@ export namespace Skill {`
`148`	`151`	`}`
`149`	`152`	`}`
`150`	`153`
`151`		`- const dirs = Array.from(new Set(Object.values(skills).map((item) => path.dirname(item.location))))`
`152`		`-`
`153`	`154`	`return {`
`154`	`155`	`skills,`
`155`		`- dirs,`
	`156`	`+ dirs: Array.from(dirs),`
`156`	`157`	`}`
`157`	`158`	`})`
`158`	`159`