Merge pull request microsoft#3712 from Microsoft/abstractExtraError

Arthur Ozga · Arthur Ozga · commit f37a7f575246 · 2015-07-02T10:59:06.000-07:00
Abstract extra error
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -8456,6 +8456,7 @@ namespace ts {
             let valueDecl = expressionType.symbol && getDeclarationOfKind(expressionType.symbol, SyntaxKind.ClassDeclaration);
             if (valueDecl && valueDecl.flags & NodeFlags.Abstract) {
                 error(node, Diagnostics.Cannot_create_an_instance_of_the_abstract_class_0, declarationNameToString(valueDecl.name));
+                return resolveErrorCall(node);
             }
 
             // TS 1.0 spec: 4.11
diff --git a/tests/baselines/reference/classAbstractInstantiations1.errors.txt b/tests/baselines/reference/classAbstractInstantiations1.errors.txt
@@ -1,8 +1,9 @@
 tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(8,1): error TS2511: Cannot create an instance of the abstract class 'A'.
-tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(10,1): error TS2511: Cannot create an instance of the abstract class 'C'.
+tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(9,1): error TS2511: Cannot create an instance of the abstract class 'A'.
+tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(11,1): error TS2511: Cannot create an instance of the abstract class 'C'.
 
 
-==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts (2 errors) ====
+==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts (3 errors) ====
     
     abstract class A {}
     
@@ -12,6 +13,9 @@ tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbst
     
     new A;
     ~~~~~
+!!! error TS2511: Cannot create an instance of the abstract class 'A'.
+    new A(1); // should report 1 error
+    ~~~~~~~~
 !!! error TS2511: Cannot create an instance of the abstract class 'A'.
     new B;
     new C;
diff --git a/tests/baselines/reference/classAbstractInstantiations1.js b/tests/baselines/reference/classAbstractInstantiations1.js
@@ -7,6 +7,7 @@ class B extends A {}
 abstract class C extends B {}
 
 new A;
+new A(1); // should report 1 error
 new B;
 new C;
 
@@ -45,6 +46,7 @@ var C = (function (_super) {
     return C;
 })(B);
 new A;
+new A(1); // should report 1 error
 new B;
 new C;
 var a;
diff --git a/tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts b/tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts
@@ -6,6 +6,7 @@ class B extends A {}
 abstract class C extends B {}
 
 new A;
+new A(1); // should report 1 error
 new B;
 new C;
 

Original file line number	Diff line number	Diff line change
`@@ -8456,6 +8456,7 @@ namespace ts {`
`8456`	`8456`	`let valueDecl = expressionType.symbol && getDeclarationOfKind(expressionType.symbol, SyntaxKind.ClassDeclaration);`
`8457`	`8457`	`if (valueDecl && valueDecl.flags & NodeFlags.Abstract) {`
`8458`	`8458`	`error(node, Diagnostics.Cannot_create_an_instance_of_the_abstract_class_0, declarationNameToString(valueDecl.name));`
	`8459`	`+ return resolveErrorCall(node);`
`8459`	`8460`	`}`
`8460`	`8461`
`8461`	`8462`	`// TS 1.0 spec: 4.11`