Filter out would-be-duplicate names from JSX attribute completion

RyanCavanaugh · RyanCavanaugh · commit ef765e56dfa2 · 2015-07-01T16:04:29.000-07:00
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -3062,20 +3062,17 @@ namespace ts {
                 }
                 else if(jsxContainer) {
                     let attrsType: Type;
-                    if (jsxContainer.kind === SyntaxKind.JsxSelfClosingElement) {
-                        // Cursor is inside a JSX self-closing element
-                        attrsType = typeChecker.getJsxElementAttributesType(<JsxSelfClosingElement>jsxContainer);
-                    }
-                    else if(jsxContainer.kind === SyntaxKind.JsxOpeningElement) {
-                        // Cursor is inside a JSX element
-                        attrsType = typeChecker.getJsxElementAttributesType(<JsxOpeningElement>jsxContainer);
-                    }
+                    if ((jsxContainer.kind === SyntaxKind.JsxSelfClosingElement) || (jsxContainer.kind === SyntaxKind.JsxOpeningElement)) {
+                        // Cursor is inside a JSX self-closing element or opening element
+                        attrsType = typeChecker.getJsxElementAttributesType(<JsxOpeningLikeElement>jsxContainer);
+
+                        if (attrsType) {
+                            symbols = filterJsxAttributes((<JsxOpeningLikeElement>jsxContainer).attributes, typeChecker.getPropertiesOfType(attrsType));
+                            isMemberCompletion = true;
+                            isNewIdentifierLocation = false;
+                            return true;
+                        }
 
-                    if (attrsType) {
-                        symbols = typeChecker.getPropertiesOfType(attrsType);
-                        isMemberCompletion = true;
-                        isNewIdentifierLocation = false;
-                        return true;
                     }
                 }
 
@@ -3476,6 +3473,22 @@ namespace ts {
             }
         }
 
+        function filterJsxAttributes(attributes: NodeArray<JsxAttribute|JsxSpreadAttribute>, symbols: Symbol[]): Symbol[] {
+            let seenNames: Map<boolean> = {};
+            for(let attr of attributes) {
+                if(attr.kind === SyntaxKind.JsxAttribute) {
+                    seenNames[(<JsxAttribute>attr).name.text] = true;
+                }
+            }
+            let result: Symbol[] = [];
+            for(let sym of symbols) {
+                if(!seenNames[sym.name]) {
+                    result.push(sym);
+                }
+            }
+            return result;
+        }
+
         function getCompletionsAtPosition(fileName: string, position: number): CompletionInfo {
             synchronizeHostData();
 
diff --git a/tests/cases/fourslash/tsxCompletion3.ts b/tests/cases/fourslash/tsxCompletion3.ts
@@ -11,3 +11,4 @@
 
 goTo.marker();
 verify.completionListContains('two');
+verify.not.completionListContains('one');

Original file line number	Diff line number	Diff line change
`@@ -11,3 +11,4 @@`
`11`	`11`
`12`	`12`	`goTo.marker();`
`13`	`13`	`verify.completionListContains('two');`
	`14`	`+verify.not.completionListContains('one');`