Change default node pos/end to -1

rbuckton · rbuckton · commit e4ebf1fe4c59 · 2015-07-02T12:57:34.000-07:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -764,8 +764,8 @@ namespace ts {
             }
             Node.prototype = {
                 kind: kind,
-                pos: 0,
-                end: 0,
+                pos: -1,
+                end: -1,
                 flags: 0,
                 parent: undefined,
             };
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -144,7 +144,7 @@ namespace ts {
             return true;
         }
 
-        return node.pos === node.end && node.kind !== SyntaxKind.EndOfFileToken;
+        return node.pos === node.end && node.pos >= 0 && node.kind !== SyntaxKind.EndOfFileToken;
     }
 
     export function nodeIsPresent(node: Node) {
@@ -1428,8 +1428,6 @@ namespace ts {
 
     export function createSynthesizedNode(kind: SyntaxKind, startsOnNewLine?: boolean): Node {
         let node = <SynthesizedNode>createNode(kind);
-        node.pos = -1;
-        node.end = -1;
         node.startsOnNewLine = startsOnNewLine;
         return node;
     }
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -7387,8 +7387,8 @@ namespace ts {
                 }
                 let proto = kind === SyntaxKind.SourceFile ? new SourceFileObject() : new NodeObject();
                 proto.kind = kind;
-                proto.pos = 0;
-                proto.end = 0;
+                proto.pos = -1;
+                proto.end = -1;
                 proto.flags = 0;
                 proto.parent = undefined;
                 Node.prototype = proto;

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ namespace ts {`
`144`	`144`	`return true;`
`145`	`145`	`}`
`146`	`146`
`147`		`- return node.pos === node.end && node.kind !== SyntaxKind.EndOfFileToken;`
	`147`	`+ return node.pos === node.end && node.pos >= 0 && node.kind !== SyntaxKind.EndOfFileToken;`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`export function nodeIsPresent(node: Node) {`
`@@ -1428,8 +1428,6 @@ namespace ts {`
`1428`	`1428`
`1429`	`1429`	`export function createSynthesizedNode(kind: SyntaxKind, startsOnNewLine?: boolean): Node {`
`1430`	`1430`	`let node = <SynthesizedNode>createNode(kind);`
`1431`		`- node.pos = -1;`
`1432`		`- node.end = -1;`
`1433`	`1431`	`node.startsOnNewLine = startsOnNewLine;`
`1434`	`1432`	`return node;`
`1435`	`1433`	`}`