Same trick for symbol.id, and always set it to 0.

DanielRosenwasser · web-flow · commit ced38f315e84 · 2021-11-09T00:34:36.000Z
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -287,12 +287,13 @@ namespace ts {
     }
 
     export function getSymbolId(symbol: Symbol): SymbolId {
-        if (!symbol.id) {
-            symbol.id = nextSymbolId;
+        let id = symbol.id;
+        if (!id) {
+            symbol.id = id = nextSymbolId;
             nextSymbolId++;
         }
 
-        return symbol.id;
+        return id;
     }
 
     export function isInstantiatedModule(node: ModuleDeclaration, preserveConstEnums: boolean) {
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -4900,7 +4900,7 @@ namespace ts {
         members?: SymbolTable;                  // Class, interface or object literal instance members
         exports?: SymbolTable;                  // Module exports
         globalExports?: SymbolTable;            // Conditional global UMD exports
-        /* @internal */ id?: SymbolId;          // Unique id (used to look up SymbolLinks)
+        /* @internal */ id: SymbolId;          // Unique id (used to look up SymbolLinks)
         /* @internal */ mergeId?: number;       // Merge id (used to look up merged symbol)
         /* @internal */ parent?: Symbol;        // Parent symbol
         /* @internal */ exportSymbol?: Symbol;  // Exported symbol associated with this symbol
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -5798,7 +5798,7 @@ namespace ts {
         this.escapedName = name;
         this.declarations = undefined;
         this.valueDeclaration = undefined;
-        this.id = undefined;
+        this.id = 0;
         this.mergeId = undefined;
         this.parent = undefined;
     }

Original file line number	Diff line number	Diff line change
`@@ -287,12 +287,13 @@ namespace ts {`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`export function getSymbolId(symbol: Symbol): SymbolId {`
`290`		`- if (!symbol.id) {`
`291`		`- symbol.id = nextSymbolId;`
	`290`	`+ let id = symbol.id;`
	`291`	`+ if (!id) {`
	`292`	`+ symbol.id = id = nextSymbolId;`
`292`	`293`	`nextSymbolId++;`
`293`	`294`	`}`
`294`	`295`
`295`		`- return symbol.id;`
	`296`	`+ return id;`
`296`	`297`	`}`
`297`	`298`
`298`	`299`	`export function isInstantiatedModule(node: ModuleDeclaration, preserveConstEnums: boolean) {`
Original file line number	Diff line number	Diff line change
`@@ -5798,7 +5798,7 @@ namespace ts {`
`5798`	`5798`	`this.escapedName = name;`
`5799`	`5799`	`this.declarations = undefined;`
`5800`	`5800`	`this.valueDeclaration = undefined;`
`5801`		`- this.id = undefined;`
	`5801`	`+ this.id = 0;`
`5802`	`5802`	`this.mergeId = undefined;`
`5803`	`5803`	`this.parent = undefined;`
`5804`	`5804`	`}`