Clean up findChildIndex (microsoft#16984)

Andy · web-flow · commit ba53b4266313 · 2017-07-07T10:15:04.000-07:00
diff --git a/src/server/scriptVersionCache.ts b/src/server/scriptVersionCache.ts
@@ -839,10 +839,9 @@ namespace ts.server {
             this.children.length--;
         }
 
-        findChildIndex(child: LineCollection) {
-            let childIndex = 0;
-            const clen = this.children.length;
-            while ((this.children[childIndex] !== child) && (childIndex < clen)) childIndex++;
+        private findChildIndex(child: LineCollection) {
+            const childIndex = this.children.indexOf(child);
+            Debug.assert(childIndex !== -1);
             return childIndex;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -839,10 +839,9 @@ namespace ts.server {`
`839`	`839`	`this.children.length--;`
`840`	`840`	`}`
`841`	`841`
`842`		`- findChildIndex(child: LineCollection) {`
`843`		`- let childIndex = 0;`
`844`		`- const clen = this.children.length;`
`845`		`- while ((this.children[childIndex] !== child) && (childIndex < clen)) childIndex++;`
	`842`	`+ private findChildIndex(child: LineCollection) {`
	`843`	`+ const childIndex = this.children.indexOf(child);`
	`844`	`+ Debug.assert(childIndex !== -1);`
`846`	`845`	`return childIndex;`
`847`	`846`	`}`
`848`	`847`