Switch devcontainer to use Node.js 18. (microsoft#55299)

DanielRosenwasser · web-flow · commit 9e4c410caa97 · 2023-08-07T15:44:15.000-07:00
Also moved certain fields to `customizations`.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,7 +1,7 @@
-# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.154.0/containers/javascript-node/.devcontainer/base.Dockerfile
+# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/javascript-node/.devcontainer/base.Dockerfile
 
-# [Choice] Node.js version: 14, 12, 10
-ARG VARIANT="14-buster"
+# [Choice] Node.js version: 18, 16, 14
+ARG VARIANT="18-buster"
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 RUN sudo -u node npm install -g hereby
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -3,20 +3,24 @@
     "build": {
         "dockerfile": "Dockerfile",
         "args": {
-            "VARIANT": "14"
+            "VARIANT": "18"
         }
     },
-    "settings": {
-        "terminal.integrated.defaultProfile.linux": "bash",
-        "terminal.integrated.profiles.linux": {
-            "bash": {
-                "path": "/bin/bash",
-                "icon": "terminal-bash",
+    "customizations": {
+        "vscode": {
+            "settings": {
+                "terminal.integrated.defaultProfile.linux": "bash",
+                "terminal.integrated.profiles.linux": {
+                    "bash": {
+                        "path": "/bin/bash",
+                        "icon": "terminal-bash"
+                    }
+                }
             },
-        },
+            "extensions": [
+                "dbaeumer.vscode-eslint"
+            ]
+        }
     },
-    "extensions": [
-        "dbaeumer.vscode-eslint"
-    ],
     "remoteUser": "node"
-}
+}
