Fix find-refs crash on JSDocNamepath (microsoft#36941)

sandersn · web-flow · commit 6b645f582b85 · 2020-02-21T15:37:11.000-08:00
JSDocNamepaths span a lot of identifiers that we don't actually care
about, so it's incorrect for createChildren to add its children as
synthetic nodes.
diff --git a/src/compiler/utilitiesPublic.ts b/src/compiler/utilitiesPublic.ts
@@ -2469,7 +2469,7 @@ namespace ts {
 
     /** True if node is of a kind that may contain comment text. */
     export function isJSDocCommentContainingNode(node: Node): boolean {
-        return node.kind === SyntaxKind.JSDocComment || isJSDocTag(node) || isJSDocTypeLiteral(node) || isJSDocSignature(node);
+        return node.kind === SyntaxKind.JSDocComment || node.kind === SyntaxKind.JSDocNamepathType || isJSDocTag(node) || isJSDocTypeLiteral(node) || isJSDocSignature(node);
     }
 
     // TODO: determine what this does before making it public.
diff --git a/tests/baselines/reference/renameJSDocNamepath.baseline b/tests/baselines/reference/renameJSDocNamepath.baseline
@@ -0,0 +1,7 @@
+/*====== /tests/cases/fourslash/renameJSDocNamepath.ts ======*/
+
+/**
+ * @type {module:foo/A} x
+ */
+var x = 1
+var [|RENAME|] = 0;
diff --git a/tests/cases/fourslash/renameJSDocNamepath.ts b/tests/cases/fourslash/renameJSDocNamepath.ts
@@ -0,0 +1,11 @@
+// @noLib: true
+
+/// <reference path='fourslash.ts'/>
+
+//// /**
+////  * @type {module:foo/A} x
+////  */
+//// var x = 1
+//// var /*0*/A = 0;
+
+verify.baselineRename("0", {});

Original file line number	Diff line number	Diff line change
`@@ -2469,7 +2469,7 @@ namespace ts {`
`2469`	`2469`
`2470`	`2470`	`/** True if node is of a kind that may contain comment text. */`
`2471`	`2471`	`export function isJSDocCommentContainingNode(node: Node): boolean {`
`2472`		`- return node.kind === SyntaxKind.JSDocComment \|\| isJSDocTag(node) \|\| isJSDocTypeLiteral(node) \|\| isJSDocSignature(node);`
	`2472`	`+ return node.kind === SyntaxKind.JSDocComment \|\| node.kind === SyntaxKind.JSDocNamepathType \|\| isJSDocTag(node) \|\| isJSDocTypeLiteral(node) \|\| isJSDocSignature(node);`
`2473`	`2473`	`}`
`2474`	`2474`
`2475`	`2475`	`// TODO: determine what this does before making it public.`