forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathedit.test.ts
More file actions
574 lines (496 loc) · 19 KB
/
Copy pathedit.test.ts
File metadata and controls
574 lines (496 loc) · 19 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
import { afterEach, describe, expect } from "bun:test"
import path from "path"
import fs from "fs/promises"
import { LayerNode } from "@opencode-ai/core/effect/layer-node"
import { Cause, Deferred, Effect, Exit, Fiber, Layer } from "effect"
import { EditTool } from "../../src/tool/edit"
import { disposeAllInstances, TestInstance } from "../fixture/fixture"
import { LSP } from "@/lsp/lsp"
import { FSUtil } from "@opencode-ai/core/fs-util"
import { Format } from "../../src/format"
import { Agent } from "../../src/agent/agent"
import { EventV2Bridge } from "../../src/event-v2-bridge"
import { Truncate } from "@/tool/truncate"
import { SessionID, MessageID } from "../../src/session/schema"
import * as Tool from "../../src/tool/tool"
import { testEffect } from "../lib/effect"
import { Watcher } from "@opencode-ai/core/filesystem/watcher"
const ctx = {
sessionID: SessionID.make("ses_test-edit-session"),
messageID: MessageID.make("msg_test"),
callID: "",
agent: "build",
abort: AbortSignal.any([]),
messages: [],
metadata: () => Effect.void,
ask: () => Effect.void,
}
afterEach(async () => {
await disposeAllInstances()
})
const layer = LayerNode.compile(
LayerNode.group([LSP.node, FSUtil.node, Format.node, EventV2Bridge.node, Truncate.node, Agent.node]),
)
const it = testEffect(layer)
const init = Effect.fn("EditToolTest.init")(function* () {
const info = yield* EditTool
return yield* info.init()
})
const run = Effect.fn("EditToolTest.run")(function* (
args: Tool.InferParameters<typeof EditTool>,
next: Tool.Context = ctx,
) {
const tool = yield* init()
return yield* tool.execute(args, next)
})
const fail = Effect.fn("EditToolTest.fail")(function* (args: Tool.InferParameters<typeof EditTool>) {
const exit = yield* run(args).pipe(Effect.exit)
if (Exit.isFailure(exit)) {
const err = Cause.squash(exit.cause)
return err instanceof Error ? err : new Error(String(err))
}
throw new Error("expected edit to fail")
})
const put = Effect.fn("EditToolTest.put")(function* (p: string, content: string) {
const fs = yield* FSUtil.Service
yield* fs.writeWithDirs(p, content)
})
const load = Effect.fn("EditToolTest.load")(function* (p: string) {
const fs = yield* FSUtil.Service
return yield* fs.readFileString(p)
})
const loadRaw = Effect.fn("EditToolTest.loadRaw")(function* (p: string) {
return yield* Effect.promise(() => fs.readFile(p, "utf-8"))
})
const makeDirectory = Effect.fn("EditToolTest.makeDirectory")(function* (p: string) {
const fs = yield* FSUtil.Service
yield* fs.makeDirectory(p)
})
const onceBus = Effect.fn("EditToolTest.onceBus")(function* (def: typeof Watcher.Event.Updated) {
const events = yield* EventV2Bridge.Service
const deferred = yield* Deferred.make<void>()
const unsub = yield* events.listen((event) => {
if (event.type === def.type) Deferred.doneUnsafe(deferred, Effect.void)
return Effect.void
})
yield* Effect.addFinalizer(() => unsub)
return deferred
})
describe("tool.edit", () => {
describe("creating new files", () => {
it.instance("creates new file when oldString is empty", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "newfile.txt")
const result = yield* run({ filePath: filepath, oldString: "", newString: "new content" })
expect(result.metadata.diff).toContain("new content")
expect(yield* load(filepath)).toBe("new content")
}),
)
it.instance("rejects empty oldString on existing files and leaves content unchanged", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "existing.cs")
const bom = String.fromCharCode(0xfeff)
const original = `${bom}using System;\n`
yield* put(filepath, original)
expect((yield* fail({ filePath: filepath, oldString: "", newString: "using Up;\n" })).message).toContain(
"oldString cannot be empty",
)
const content = yield* loadRaw(filepath)
expect(content).toBe(original)
}),
)
it.instance("creates new file with nested directories", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "nested", "dir", "file.txt")
yield* run({ filePath: filepath, oldString: "", newString: "nested file" })
expect(yield* load(filepath)).toBe("nested file")
}),
)
it.instance("emits add event for new files", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const updated = yield* onceBus(Watcher.Event.Updated)
yield* run({ filePath: path.join(test.directory, "new.txt"), oldString: "", newString: "content" })
yield* Deferred.await(updated)
}),
)
})
describe("editing existing files", () => {
it.instance("replaces text in existing file", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "existing.txt")
yield* put(filepath, "old content here")
const result = yield* run({ filePath: filepath, oldString: "old content", newString: "new content" })
expect(result.output).toContain("Edit applied successfully")
expect(yield* load(filepath)).toBe("new content here")
}),
)
it.instance("replaces the first visible line in BOM files", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "existing.cs")
const bom = String.fromCharCode(0xfeff)
yield* put(filepath, `${bom}using System;\nclass Test {}\n`)
const result = yield* run({ filePath: filepath, oldString: "using System;", newString: "using Up;" })
expect(result.metadata.diff).toContain("-using System;")
expect(result.metadata.diff).toContain("+using Up;")
expect(result.metadata.diff).not.toContain(bom)
const content = yield* loadRaw(filepath)
expect(content.charCodeAt(0)).toBe(0xfeff)
expect(content.slice(1)).toBe("using Up;\nclass Test {}\n")
}),
)
it.instance("throws error when file does not exist", () =>
Effect.gen(function* () {
const test = yield* TestInstance
expect(
(yield* fail({ filePath: path.join(test.directory, "nonexistent.txt"), oldString: "old", newString: "new" }))
.message,
).toContain("not found")
}),
)
it.instance("throws error when oldString equals newString", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "content")
expect((yield* fail({ filePath: filepath, oldString: "same", newString: "same" })).message).toContain(
"identical",
)
}),
)
it.instance("throws error when oldString not found in file", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "actual content")
expect(yield* fail({ filePath: filepath, oldString: "not in file", newString: "replacement" })).toBeInstanceOf(
Error,
)
}),
)
it.instance("rejects loose block-anchor matches and leaves content unchanged", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.ts")
const original = [
"function configure() {",
" keepImportantState()",
" removeAllUserData()",
" archiveBackups()",
" auditLog()",
"}",
].join("\n")
yield* put(filepath, original)
expect(
(yield* fail({
filePath: filepath,
oldString: ["function configure() {", " const enabled = true", "}"].join("\n"),
newString: ["function configure() {", " const enabled = false", "}"].join("\n"),
})).message,
).toContain("Could not find oldString")
expect(yield* load(filepath)).toBe(original)
}),
)
it.instance("rejects block-anchor matches with unrelated middle content", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.ts")
const original = ["function configure() {", " removeAllUserData()", "}"].join("\n")
yield* put(filepath, original)
expect(
(yield* fail({
filePath: filepath,
oldString: ["function configure() {", " const enabled = true", "}"].join("\n"),
newString: ["function configure() {", " const enabled = false", "}"].join("\n"),
})).message,
).toContain("Could not find oldString")
expect(yield* load(filepath)).toBe(original)
}),
)
it.instance("replaces all occurrences with replaceAll option", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "foo bar foo baz foo")
yield* run({ filePath: filepath, oldString: "foo", newString: "qux", replaceAll: true })
expect(yield* load(filepath)).toBe("qux bar qux baz qux")
}),
)
it.instance("emits change event for existing files", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "original")
const updated = yield* onceBus(Watcher.Event.Updated)
yield* run({ filePath: filepath, oldString: "original", newString: "modified" })
yield* Deferred.await(updated)
}),
)
})
describe("edge cases", () => {
it.instance("handles multiline replacements", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "line1\nline2\nline3")
yield* run({ filePath: filepath, oldString: "line2", newString: "new line 2\nextra line" })
expect(yield* load(filepath)).toBe("line1\nnew line 2\nextra line\nline3")
}),
)
it.instance("handles CRLF line endings", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "line1\r\nold\r\nline3")
yield* run({ filePath: filepath, oldString: "old", newString: "new" })
expect(yield* load(filepath)).toBe("line1\r\nnew\r\nline3")
}),
)
it.instance("throws error when oldString equals newString", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "content")
expect((yield* fail({ filePath: filepath, oldString: "", newString: "" })).message).toContain("identical")
}),
)
it.instance("throws error when path is directory", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const dirpath = path.join(test.directory, "adir")
yield* makeDirectory(dirpath)
expect((yield* fail({ filePath: dirpath, oldString: "old", newString: "new" })).message).toContain("directory")
}),
)
it.instance("tracks file diff statistics", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "line1\nline2\nline3")
const result = yield* run({ filePath: filepath, oldString: "line2", newString: "new line a\nnew line b" })
expect(result.metadata.filediff).toBeDefined()
expect(result.metadata.filediff.file).toBe(filepath)
expect(result.metadata.filediff.additions).toBeGreaterThan(0)
}),
)
})
describe("line endings", () => {
const old = "alpha\nbeta\ngamma"
const next = "alpha\nbeta-updated\ngamma"
const alt = "alpha\nbeta\nomega"
const normalize = (text: string, ending: "\n" | "\r\n") => {
const normalized = text.replaceAll("\r\n", "\n")
if (ending === "\n") return normalized
return normalized.replaceAll("\n", "\r\n")
}
const count = (content: string) => {
const crlf = content.match(/\r\n/g)?.length ?? 0
const lf = content.match(/\n/g)?.length ?? 0
return {
crlf,
lf: lf - crlf,
}
}
const expectLf = (content: string) => {
const counts = count(content)
expect(counts.crlf).toBe(0)
expect(counts.lf).toBeGreaterThan(0)
}
const expectCrlf = (content: string) => {
const counts = count(content)
expect(counts.lf).toBe(0)
expect(counts.crlf).toBeGreaterThan(0)
}
type Input = {
content: string
oldString: string
newString: string
replaceAll?: boolean
}
const apply = Effect.fn("EditToolTest.lineEndings.apply")(function* (input: Input) {
const test = yield* TestInstance
const filePath = path.join(test.directory, "test.txt")
yield* put(filePath, input.content)
yield* run({
filePath,
oldString: input.oldString,
newString: input.newString,
replaceAll: input.replaceAll,
})
return yield* load(filePath)
})
it.instance("preserves LF with LF multi-line strings", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\n")
const output = yield* apply({
content,
oldString: normalize(old, "\n"),
newString: normalize(next, "\n"),
})
expect(output).toBe(normalize(next + "\n", "\n"))
expectLf(output)
}),
)
it.instance("preserves CRLF with CRLF multi-line strings", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\r\n")
const output = yield* apply({
content,
oldString: normalize(old, "\r\n"),
newString: normalize(next, "\r\n"),
})
expect(output).toBe(normalize(next + "\n", "\r\n"))
expectCrlf(output)
}),
)
it.instance("preserves LF when old/new use CRLF", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\n")
const output = yield* apply({
content,
oldString: normalize(old, "\r\n"),
newString: normalize(next, "\r\n"),
})
expect(output).toBe(normalize(next + "\n", "\n"))
expectLf(output)
}),
)
it.instance("preserves CRLF when old/new use LF", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\r\n")
const output = yield* apply({
content,
oldString: normalize(old, "\n"),
newString: normalize(next, "\n"),
})
expect(output).toBe(normalize(next + "\n", "\r\n"))
expectCrlf(output)
}),
)
it.instance("preserves LF when newString uses CRLF", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\n")
const output = yield* apply({
content,
oldString: normalize(old, "\n"),
newString: normalize(next, "\r\n"),
})
expect(output).toBe(normalize(next + "\n", "\n"))
expectLf(output)
}),
)
it.instance("preserves CRLF when newString uses LF", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\r\n")
const output = yield* apply({
content,
oldString: normalize(old, "\r\n"),
newString: normalize(next, "\n"),
})
expect(output).toBe(normalize(next + "\n", "\r\n"))
expectCrlf(output)
}),
)
it.instance("preserves LF with mixed old/new line endings", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\n")
const output = yield* apply({
content,
oldString: "alpha\nbeta\r\ngamma",
newString: "alpha\r\nbeta\nomega",
})
expect(output).toBe(normalize(alt + "\n", "\n"))
expectLf(output)
}),
)
it.instance("preserves CRLF with mixed old/new line endings", () =>
Effect.gen(function* () {
const content = normalize(old + "\n", "\r\n")
const output = yield* apply({
content,
oldString: "alpha\r\nbeta\ngamma",
newString: "alpha\nbeta\r\nomega",
})
expect(output).toBe(normalize(alt + "\n", "\r\n"))
expectCrlf(output)
}),
)
it.instance("replaceAll preserves LF for multi-line blocks", () =>
Effect.gen(function* () {
const blockOld = "alpha\nbeta"
const blockNew = "alpha\nbeta-updated"
const content = normalize(blockOld + "\n" + blockOld + "\n", "\n")
const output = yield* apply({
content,
oldString: normalize(blockOld, "\n"),
newString: normalize(blockNew, "\n"),
replaceAll: true,
})
expect(output).toBe(normalize(blockNew + "\n" + blockNew + "\n", "\n"))
expectLf(output)
}),
)
it.instance("replaceAll preserves CRLF for multi-line blocks", () =>
Effect.gen(function* () {
const blockOld = "alpha\nbeta"
const blockNew = "alpha\nbeta-updated"
const content = normalize(blockOld + "\n" + blockOld + "\n", "\r\n")
const output = yield* apply({
content,
oldString: normalize(blockOld, "\r\n"),
newString: normalize(blockNew, "\r\n"),
replaceAll: true,
})
expect(output).toBe(normalize(blockNew + "\n" + blockNew + "\n", "\r\n"))
expectCrlf(output)
}),
)
})
describe("concurrent editing", () => {
it.instance("preserves concurrent edits to different sections of the same file", () =>
Effect.gen(function* () {
const test = yield* TestInstance
const filepath = path.join(test.directory, "file.txt")
yield* put(filepath, "top = 0\nmiddle = keep\nbottom = 0\n")
const firstAsk = yield* Deferred.make<void>()
let asks = 0
const delayedCtx = {
...ctx,
ask: () =>
Effect.gen(function* () {
asks++
if (asks !== 1) return
yield* Deferred.succeed(firstAsk, undefined)
yield* Effect.sleep("50 millis")
}),
}
const first = yield* run(
{
filePath: filepath,
oldString: "top = 0",
newString: "top = 1",
},
delayedCtx,
).pipe(Effect.forkScoped)
yield* Deferred.await(firstAsk)
yield* Effect.all([
Fiber.join(first),
run(
{
filePath: filepath,
oldString: "bottom = 0",
newString: "bottom = 2",
},
delayedCtx,
),
])
expect(yield* load(filepath)).toBe("top = 1\nmiddle = keep\nbottom = 2\n")
}),
)
})
})