Small test fixes

fbuecklers · fbuecklers · commit b05b1bbe6f15 · 2017-11-18T17:57:52.000+01:00
diff --git a/src/test/java/com/github/dockerjava/cmd/CreateContainerCmdIT.java b/src/test/java/com/github/dockerjava/cmd/CreateContainerCmdIT.java
@@ -148,19 +148,18 @@ public void createContainerWithVolumesFrom() throws DockerException {
         String container1Name = UUID.randomUUID().toString();
         CreateVolumeResponse volume1Info = dockerRule.getClient().createVolumeCmd().exec();
         CreateVolumeResponse volume2Info = dockerRule.getClient().createVolumeCmd().exec();
-        String mountpoint1 = volume1Info.getMountpoint();
-        String mountpoint2 = volume2Info.getMountpoint();
-        Volume volume1 = new Volume(mountpoint1);
-        Volume volume2 = new Volume(mountpoint2);
 
-        Bind bind1 = new Bind("/src/webapp1", volume1);
-        Bind bind2 = new Bind("/src/webapp2", volume2);
+        Volume volume1 = new Volume("/src/webapp1");
+        Volume volume2 = new Volume("/src/webapp2");
+        Bind bind1 = new Bind(volume1Info.getName(), volume1);
+        Bind bind2 = new Bind(volume2Info.getName(), volume2);
 
         // create a running container with bind mounts
         CreateContainerResponse container1 = dockerRule.getClient().createContainerCmd(DEFAULT_IMAGE)
                 .withCmd("sleep", "9999")
                 .withName(container1Name)
-                .withBinds(bind1, bind2).exec();
+                .withBinds(bind1, bind2)
+                .exec();
 
         LOG.info("Created container1 {}", container1.toString());
 
@@ -185,6 +184,7 @@ public void createContainerWithVolumesFrom() throws DockerException {
         // No volumes are created, the information is just stored in .HostConfig.VolumesFrom
         assertThat(inspectContainerResponse2.getHostConfig().getVolumesFrom(),
                 hasItemInArray(new VolumesFrom(container1Name)));
+        assertThat(inspectContainerResponse1, mountedVolumes(containsInAnyOrder(volume1, volume2)));
 
         // To ensure that the information stored in VolumesFrom really is considered
         // when starting the container, we start it and verify that it has the same
diff --git a/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java b/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java
@@ -10,7 +10,6 @@
 import com.github.dockerjava.api.model.Info;
 import com.github.dockerjava.api.model.PullResponseItem;
 import com.github.dockerjava.core.RemoteApiVersion;
-import com.github.dockerjava.core.command.PullImageCmdImpl;
 import com.github.dockerjava.core.command.PullImageResultCallback;
 import com.github.dockerjava.utils.RegistryUtils;
 import org.junit.Rule;
@@ -26,7 +25,6 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.lessThanOrEqualTo;
 import static org.hamcrest.Matchers.notNullValue;
-import static org.junit.Assert.assertEquals;
 
 public class PullImageCmdIT extends CmdIT {
     private static final Logger LOG = LoggerFactory.getLogger(PullImageCmdIT.class);
@@ -40,19 +38,6 @@ public Void exec(PullImageCmd command, ResultCallback<PullResponseItem> resultCa
         };
     };
 
-    @Test
-    public void nullAuthConfig() throws Exception {
-        PullImageCmdImpl pullImageCmd = new PullImageCmdImpl(NOP_EXEC, null, "");
-        try {
-            pullImageCmd.withAuthConfig(null);
-            throw new AssertionError();
-        } catch (Exception e) {
-            assertEquals(e.getMessage(), "authConfig was not specified");
-        } finally {
-            pullImageCmd.close();
-        }
-    }
-
     @Test
     public void testPullImage() throws Exception {
         Info info = dockerRule.getClient().infoCmd().exec();
