Adjust the docker api version exception type

fbuecklers · fbuecklers · commit 9a937a3d0242 · 2017-11-07T13:21:12.000+01:00
diff --git a/src/main/java/com/github/dockerjava/core/RemoteApiVersion.java b/src/main/java/com/github/dockerjava/core/RemoteApiVersion.java
@@ -80,6 +80,7 @@ public class RemoteApiVersion implements Serializable {
     public static final RemoteApiVersion VERSION_1_26 = RemoteApiVersion.create(1, 26);
     public static final RemoteApiVersion VERSION_1_27 = RemoteApiVersion.create(1, 27);
     public static final RemoteApiVersion VERSION_1_29 = RemoteApiVersion.create(1, 29);
+    public static final RemoteApiVersion VERSION_1_30 = RemoteApiVersion.create(1, 30);
 
 
     /**
diff --git a/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java b/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java
@@ -133,7 +133,7 @@ public void testPullImageWithNoAuth() throws Exception {
         String imgName = RegistryUtils.createPrivateImage(dockerRule, "pull-image-with-no-auth");
 
         if (isNotSwarm(dockerRule.getClient()) && getVersion(dockerRule.getClient())
-                .isGreater(RemoteApiVersion.VERSION_1_27)) {
+                .isGreaterOrEqual(RemoteApiVersion.VERSION_1_30)) {
             exception.expect(InternalServerErrorException.class);
         } else {
             exception.expect(DockerClientException.class);
@@ -158,7 +158,7 @@ public void testPullImageWithInvalidAuth() throws Exception {
         String imgName = RegistryUtils.createPrivateImage(dockerRule, "pull-image-with-invalid-auth");
 
         if (isNotSwarm(dockerRule.getClient()) && getVersion(dockerRule.getClient())
-                .isGreater(RemoteApiVersion.VERSION_1_27)) {
+                .isGreaterOrEqual(RemoteApiVersion.VERSION_1_30)) {
             exception.expect(InternalServerErrorException.class);
         } else {
             exception.expect(DockerClientException.class);
diff --git a/src/test/java/com/github/dockerjava/utils/RegistryUtils.java b/src/test/java/com/github/dockerjava/utils/RegistryUtils.java
@@ -100,7 +100,7 @@ public static String createPrivateImage(DockerRule dockerRule, String tagName) t
         dockerRule.getClient().removeImageCmd(imgNameWithTag)
                 .exec();
 
-        //ensures that the image is available
+        //ensures that the image is available, the private registry needs some time to reflect a tag push
         Thread.sleep(5000);
 
         return imgNameWithTag;
