[[ BrowserWidget ]] Fix faulty ref counting logic resulting to non-release of browsers

livecodeian · livecodeian · commit bbd2312e251f · 2015-09-04T21:17:22.000+01:00
diff --git a/libbrowser/src/libbrowser.cpp b/libbrowser/src/libbrowser.cpp
@@ -27,7 +27,7 @@
 
 MCBrowserRefCounted::MCBrowserRefCounted()
 {
-	m_ref_count = 0;
+	m_ref_count = 1;
 }
 
 void MCBrowserRefCounted::Retain()
@@ -37,7 +37,7 @@ void MCBrowserRefCounted::Retain()
 
 void MCBrowserRefCounted::Release()
 {
-	if (--m_ref_count > 1)
+	if (m_ref_count-- > 1)
 		return;
 	
 	Destroy();

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`
`28`	`28`	`MCBrowserRefCounted::MCBrowserRefCounted()`
`29`	`29`	`{`
`30`		`- m_ref_count = 0;`
	`30`	`+ m_ref_count = 1;`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`void MCBrowserRefCounted::Retain()`
`@@ -37,7 +37,7 @@ void MCBrowserRefCounted::Retain()`
`37`	`37`
`38`	`38`	`void MCBrowserRefCounted::Release()`
`39`	`39`	`{`
`40`		`- if (--m_ref_count > 1)`
	`40`	`+ if (m_ref_count-- > 1)`
`41`	`41`	`return;`
`42`	`42`
`43`	`43`	`Destroy();`