Add test for python_venv language

asottile · asottile · commit b5af5a5b2761 · 2018-05-12T11:37:13.000-07:00
diff --git a/pre_commit/languages/python.py b/pre_commit/languages/python.py
@@ -16,7 +16,6 @@
 
 
 ENVIRONMENT_DIR = 'py_env'
-HEALTH_MODS = ('datetime', 'io', 'os', 'ssl', 'weakref')
 
 
 def bin_dir(venv):
@@ -120,7 +119,8 @@ def in_env(prefix, language_version):
     def healthy(prefix, language_version):
         with in_env(prefix, language_version):
             retcode, _, _ = cmd_output(
-                'python', '-c', 'import {}'.format(','.join(HEALTH_MODS)),
+                'python', '-c',
+                'import ctypes, datetime, io, os, ssl, weakref',
                 retcode=None,
             )
         return retcode == 0
diff --git a/testing/resources/python3_hooks_repo/py3_hook.py b/testing/resources/python3_hooks_repo/py3_hook.py
@@ -3,7 +3,7 @@
 import sys
 
 
-def func():
+def main():
     print(sys.version_info[0])
     print(repr(sys.argv[1:]))
     print('Hello World')
diff --git a/testing/resources/python3_hooks_repo/setup.py b/testing/resources/python3_hooks_repo/setup.py
@@ -1,11 +1,8 @@
-from setuptools import find_packages
 from setuptools import setup
 
 setup(
     name='python3_hook',
     version='0.0.0',
-    packages=find_packages('.'),
-    entry_points={
-        'console_scripts': ['python3-hook = python3_hook.main:func'],
-    },
+    py_modules=['py3_hook'],
+    entry_points={'console_scripts': ['python3-hook = py3_hook:main']},
 )
diff --git a/testing/resources/python_hooks_repo/foo.py b/testing/resources/python_hooks_repo/foo.py
@@ -3,7 +3,7 @@
 import sys
 
 
-def func():
+def main():
     print(repr(sys.argv[1:]))
     print('Hello World')
     return 0
diff --git a/testing/resources/python_hooks_repo/foo/__init__.py b/testing/resources/python_hooks_repo/foo/__init__.py
diff --git a/testing/resources/python_hooks_repo/setup.py b/testing/resources/python_hooks_repo/setup.py
@@ -1,11 +1,8 @@
-from setuptools import find_packages
 from setuptools import setup
 
 setup(
-    name='Foo',
+    name='foo',
     version='0.0.0',
-    packages=find_packages('.'),
-    entry_points={
-        'console_scripts': ['foo = foo.main:func'],
-    },
+    py_modules=['foo'],
+    entry_points={'console_scripts': ['foo = foo:main']},
 )
diff --git a/testing/resources/python_venv_hooks_repo/.pre-commit-hooks.yaml b/testing/resources/python_venv_hooks_repo/.pre-commit-hooks.yaml
@@ -0,0 +1,5 @@
+-   id: foo
+    name: Foo
+    entry: foo
+    language: python_venv
+    files: \.py$
diff --git a/testing/resources/python_venv_hooks_repo/foo.py b/testing/resources/python_venv_hooks_repo/foo.py
@@ -0,0 +1,9 @@
+from __future__ import print_function
+
+import sys
+
+
+def main():
+    print(repr(sys.argv[1:]))
+    print('Hello World')
+    return 0
diff --git a/testing/resources/python_venv_hooks_repo/foo/__init__.py b/testing/resources/python_venv_hooks_repo/foo/__init__.py
diff --git a/testing/resources/python_venv_hooks_repo/setup.py b/testing/resources/python_venv_hooks_repo/setup.py
@@ -0,0 +1,8 @@
+from setuptools import setup
+
+setup(
+    name='foo',
+    version='0.0.0',
+    py_modules=['foo'],
+    entry_points={'console_scripts': ['foo = foo:main']},
+)
diff --git a/testing/util.py b/testing/util.py
@@ -78,6 +78,20 @@ def platform_supports_pcre():
 )
 
 
+def supports_venv():  # pragma: no cover (platform specific)
+    try:
+        __import__('ensurepip')
+        __import__('venv')
+        return True
+    except ImportError:
+        return False
+
+
+xfailif_no_venv = pytest.mark.xfail(
+    not supports_venv(), reason='Does not support venv module',
+)
+
+
 def run_opts(
         all_files=False,
         files=(),
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -33,6 +33,7 @@
 from testing.util import skipif_cant_run_swift
 from testing.util import xfailif_broken_deep_listdir
 from testing.util import xfailif_no_pcre_support
+from testing.util import xfailif_no_venv
 from testing.util import xfailif_windows_no_ruby
 
 
@@ -111,6 +112,15 @@ def test_python_hook_weird_setup_cfg(tempdir_factory, store):
         )
 
 
+@xfailif_no_venv
+def test_python_venv(tempdir_factory, store):  # pragma: no cover (no venv)
+    _test_hook_repo(
+        tempdir_factory, store, 'python_venv_hooks_repo',
+        'foo', [os.devnull],
+        b"['" + five.to_bytes(os.devnull) + b"']\nHello World\n",
+    )
+
+
 @pytest.mark.integration
 def test_switch_language_versions_doesnt_clobber(tempdir_factory, store):
     # We're using the python3 repo because it prints the python version
