Skip printing headers when --silent in api

AliabbasMerchant · AliabbasMerchant · commit aa43c55f60d4 · 2020-06-29T07:13:06.000+05:30
diff --git a/pkg/cmd/api/api.go b/pkg/cmd/api/api.go
@@ -218,7 +218,7 @@ func apiRun(opts *ApiOptions) error {
 }
 
 func processResponse(resp *http.Response, opts *ApiOptions) (endCursor string, err error) {
-	if opts.ShowResponseHeaders {
+	if opts.ShowResponseHeaders && !opts.Silent {
 		fmt.Fprintln(opts.IO.Out, resp.Proto, resp.Status)
 		printHeaders(opts.IO.Out, resp.Header, opts.IO.ColorEnabled())
 		fmt.Fprint(opts.IO.Out, "\r\n")
diff --git a/pkg/cmd/api/api_test.go b/pkg/cmd/api/api_test.go
@@ -467,8 +467,9 @@ func Test_apiRun_silent(t *testing.T) {
 			}
 			return &http.Client{Transport: tr}, nil
 		},
-		RequestPath: "issues",
-		Silent:      true,
+		RequestPath:         "issues",
+		ShowResponseHeaders: true,
+		Silent:              true,
 	}
 
 	err := apiRun(&options)

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func apiRun(opts *ApiOptions) error {`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`func processResponse(resp http.Response, opts ApiOptions) (endCursor string, err error) {`
`221`		`- if opts.ShowResponseHeaders {`
	`221`	`+ if opts.ShowResponseHeaders && !opts.Silent {`
`222`	`222`	`fmt.Fprintln(opts.IO.Out, resp.Proto, resp.Status)`
`223`	`223`	`printHeaders(opts.IO.Out, resp.Header, opts.IO.ColorEnabled())`
`224`	`224`	`fmt.Fprint(opts.IO.Out, "\r\n")`
Original file line number	Diff line number	Diff line change
`@@ -467,8 +467,9 @@ func Test_apiRun_silent(t *testing.T) {`
`467`	`467`	`}`
`468`	`468`	`return &http.Client{Transport: tr}, nil`
`469`	`469`	`},`
`470`		`- RequestPath: "issues",`
`471`		`- Silent: true,`
	`470`	`+ RequestPath: "issues",`
	`471`	`+ ShowResponseHeaders: true,`
	`472`	`+ Silent: true,`
`472`	`473`	`}`
`473`	`474`
`474`	`475`	`err := apiRun(&options)`