propagate error from closure

fsmiamoto · fsmiamoto · commit 800be370def4 · 2020-08-12T09:18:43.000-03:00
diff --git a/pkg/cmd/api/api.go b/pkg/cmd/api/api.go
@@ -300,16 +300,17 @@ func fillPlaceholders(value string, opts *ApiOptions) (string, error) {
 		return value, err
 	}
 
-	var branch string
-
 	filled := placeholderRE.ReplaceAllStringFunc(value, func(m string) string {
 		switch m {
 		case ":owner":
 			return baseRepo.RepoOwner()
 		case ":repo":
 			return baseRepo.RepoName()
 		case ":branch":
-			branch, err = opts.Branch()
+			branch, e := opts.Branch()
+			if e != nil {
+				err = e
+			}
 			return branch
 		default:
 			panic(fmt.Sprintf("invalid placeholder: %q", m))
