API improvement : Drain response Body inside func HasScopes (cli#1428)

itsksaurabh · Kumar Saurabh · web-flow · commit 78124a971636 · 2020-07-28T14:56:17.000+02:00
Ensure the response body is fully read and closed to reuse the same TCPconnection.

Co-authored-by: Kumar Saurabh &lt;kumarsaurabh@Kumars-MacBook-Air.local&gt;
diff --git a/api/client.go b/api/client.go
@@ -212,7 +212,13 @@ func (c Client) HasScopes(wantedScopes ...string) (bool, string, error) {
 	if err != nil {
 		return false, "", err
 	}
-	defer res.Body.Close()
+
+	defer func() {
+		// Ensure the response body is fully read and closed
+		// before we reconnect, so that we reuse the same TCPconnection.
+		_, _ = io.Copy(ioutil.Discard, res.Body)
+		res.Body.Close()
+	}()
 
 	if res.StatusCode != 200 {
 		return false, "", handleHTTPError(res)
