clarify newline normalization

vilmibm · vilmibm · commit 4592aaf63de9 · 2020-01-13T15:36:43.000-06:00
diff --git a/utils/utils.go b/utils/utils.go
@@ -56,11 +56,8 @@ func searchBrowserLauncher(goos string) (browser string) {
 }
 
 func normalizeNewlines(d []byte) []byte {
-	// from https://github.com/MichaelMure/go-term-markdown/issues/1#issuecomment-570702862
-	// replace CR LF \r\n (windows) with LF \n (unix)
-	d = bytes.Replace(d, []byte{13, 10}, []byte{10}, -1)
-	// replace CF \r (mac) with LF \n (unix)
-	d = bytes.Replace(d, []byte{13}, []byte{10}, -1)
+	d = bytes.Replace(d, []byte("\r\n"), []byte("\n"), -1)
+	d = bytes.Replace(d, []byte("\r"), []byte("\n"), -1)
 	return d
 }
 

Original file line number	Diff line number	Diff line change
`@@ -56,11 +56,8 @@ func searchBrowserLauncher(goos string) (browser string) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`func normalizeNewlines(d []byte) []byte {`
`59`		`- // from https://github.com/MichaelMure/go-term-markdown/issues/1#issuecomment-570702862`
`60`		`- // replace CR LF \r\n (windows) with LF \n (unix)`
`61`		`- d = bytes.Replace(d, []byte{13, 10}, []byte{10}, -1)`
`62`		`- // replace CF \r (mac) with LF \n (unix)`
`63`		`- d = bytes.Replace(d, []byte{13}, []byte{10}, -1)`
	`59`	`+ d = bytes.Replace(d, []byte("\r\n"), []byte("\n"), -1)`
	`60`	`+ d = bytes.Replace(d, []byte("\r"), []byte("\n"), -1)`
`64`	`61`	`return d`
`65`	`62`	`}`
`66`	`63`