PullRequestForBranch: fix outdated error message

mislav · mislav · commit 2ac68cc53437 · 2020-10-28T15:50:59.000+01:00
This method doesn't necessarily search through open pull requests.
diff --git a/api/queries_pr.go b/api/queries_pr.go
@@ -748,7 +748,7 @@ func PullRequestForBranch(client *Client, repo ghrepo.Interface, baseBranch, hea
 		}
 	}
 
-	return nil, &NotFoundError{fmt.Errorf("no open pull requests found for branch %q", headBranch)}
+	return nil, &NotFoundError{fmt.Errorf("no pull requests found for branch %q", headBranch)}
 }
 
 // CreatePullRequest creates a pull request in a GitHub repository
diff --git a/pkg/cmd/pr/diff/diff_test.go b/pkg/cmd/pr/diff/diff_test.go
@@ -171,7 +171,7 @@ func TestPRDiff_no_current_pr(t *testing.T) {
 	if err == nil {
 		t.Fatal("expected error")
 	}
-	assert.Equal(t, `no open pull requests found for branch "feature"`, err.Error())
+	assert.Equal(t, `no pull requests found for branch "feature"`, err.Error())
 }
 
 func TestPRDiff_argument_not_found(t *testing.T) {
diff --git a/pkg/cmd/pr/view/view_test.go b/pkg/cmd/pr/view/view_test.go
@@ -536,7 +536,7 @@ func TestPRView_web_noResultsForBranch(t *testing.T) {
 	defer restoreCmd()
 
 	_, err := runCommand(http, "blueberries", true, "-w")
-	if err == nil || err.Error() != `no open pull requests found for branch "blueberries"` {
+	if err == nil || err.Error() != `no pull requests found for branch "blueberries"` {
 		t.Errorf("error running command `pr view`: %v", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -748,7 +748,7 @@ func PullRequestForBranch(client *Client, repo ghrepo.Interface, baseBranch, hea`
`748`	`748`	`}`
`749`	`749`	`}`
`750`	`750`
`751`		`- return nil, &NotFoundError{fmt.Errorf("no open pull requests found for branch %q", headBranch)}`
	`751`	`+ return nil, &NotFoundError{fmt.Errorf("no pull requests found for branch %q", headBranch)}`
`752`	`752`	`}`
`753`	`753`
`754`	`754`	`// CreatePullRequest creates a pull request in a GitHub repository`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ func TestPRDiff_no_current_pr(t *testing.T) {`
`171`	`171`	`if err == nil {`
`172`	`172`	`t.Fatal("expected error")`
`173`	`173`	`}`
`174`		- assert.Equal(t, `no open pull requests found for branch "feature"`, err.Error())
	`174`	+ assert.Equal(t, `no pull requests found for branch "feature"`, err.Error())
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`func TestPRDiff_argument_not_found(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ func TestPRView_web_noResultsForBranch(t *testing.T) {`
`536`	`536`	`defer restoreCmd()`
`537`	`537`
`538`	`538`	`_, err := runCommand(http, "blueberries", true, "-w")`
`539`		- if err == nil \|\| err.Error() != `no open pull requests found for branch "blueberries"` {
	`539`	+ if err == nil \|\| err.Error() != `no pull requests found for branch "blueberries"` {
`540`	`540`	t.Errorf("error running command `pr view`: %v", err)
`541`	`541`	`}`
`542`	`542`