Template: PR branch name? #131

Activity

1. alexcanessa

   added

   enhancement

   good first issue

   and removed

   good first issue

   on Jan 24, 2018
2. alexcanessa commented on Jan 24, 2018

   

   alexcanessa

   on Jan 24, 2018

   Member

   More actions

   Hi @svanzoest the only problem with this task is that right now we're using the issue API to get PRs (as a pull_request is - technically - an issue).

   The Solution:

   1. Call the get single PR when the issue has been identified as PR:
      

      github-release-notes/lib/src/Gren.js

      Lines 784 to 789 in 3e6b2e4

      	_filterIssue(issue) {
      	const { dataSource } = this.options;
      	return (issue.pull_request ? dataSource === 'prs' : dataSource === 'issues' | dataSource === 'milestones') && !this._lablesAreIgnored(issue.labels) &&
      	!((this.options.onlyMilestones || dataSource === 'milestones') && !issue.milestone);
      	}

   2. Pass the branch information to the template function:
      

      github-release-notes/lib/src/Gren.js

      Lines 472 to 479 in 3e6b2e4

      	_templateIssue(issue) {
      	return generate({
      	labels: this._templateLabels(issue),
      	name: issue.title,
      	text: '#' + issue.number,
      	url: issue.html_url
      	}, this.options.template.issue);
      	}
3. alexcanessa

   closed this as completedin #164on May 23, 2018